Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #26318 #26381

Closed
wants to merge 1 commit into from
Closed

Revert #26318 #26381

wants to merge 1 commit into from

Conversation

delvh
Copy link
Member

@delvh delvh commented Aug 7, 2023

Part of the quest to prevent users from silently losing data started by #26380.

@delvh delvh added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. theme/revert labels Aug 7, 2023
@delvh delvh added this to the 1.20.3 milestone Aug 7, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 7, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 7, 2023
@lunny
Copy link
Member

lunny commented Aug 8, 2023

But it will make the future storage management more difficult. Even #26380 merged, users cannot diff the different types' data themselves. And then users will stuck there, they don't know how to handle the error displayed on #26380 and maintainers also cannot know how to help.

@wxiaoguang
Copy link
Contributor

See the comment #26380 (comment)

@delvh
Copy link
Member Author

delvh commented Aug 10, 2023

Seems like we won't revert the other PR.

@delvh delvh closed this Aug 10, 2023
@GiteaBot GiteaBot removed this from the 1.20.3 milestone Aug 10, 2023
@delvh delvh mentioned this pull request Aug 13, 2023
Closed
@delvh delvh deleted the revert-26318 branch October 19, 2023 20:34
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@delvh @lunny @wxiaoguang @GiteaBot