Change default sort order

[kaz]

Change default sort key to updated_unix from created_unix
(repositories order on explore page)

it was suggested on (#2442)

Closes #2442

[codecov-io]

Codecov Report

Merging #2647 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2647      +/-   ##
==========================================
+ Coverage   27.12%   27.13%   +<.01%     
==========================================
  Files          86       86              
  Lines       17064    17061       -3     
==========================================
  Hits         4629     4629              
+ Misses      11757    11754       -3     
  Partials      678      678

Impacted Files	Coverage Δ
routers/user/profile.go	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa962de...68af474. Read the comment docs.

[lafriks]

LGTM

[daviian]

You have changed sorting of users instead of repositories..

[kaz]

oops, fixed it

[daviian]

LGTM

[Morlinest]

Give me some time to test it, I think there is little problem.

[Morlinest]

@lafriks @daviian This PR can't be merged, there is reason for current default. It's used in conjunction with UI, where default option for sorting is newest.

@kaz You have to change UI (html templates) too. It's not so simple like changing 1 value :).

[lafriks]

When testing list looked correct for me, did not check sort menu, good catch

[lafriks]

Need to fix also UI as @Morlinest pointed out

[kaz]

I fixed that UI problem.
Sorry for my insufficient testing 🙇

[Morlinest]

@kaz NP. You are not done yet :D. You have to add case "newest": to models.RenderRepoSearch().

[Morlinest]

@kaz Please check every place, where your changes are used. If I search explore/search, it's used in 4 other templates. First that mean that you are changing more than 1 search page (@lafriks @daviian do you want to change it too?), second, I think you have to add case "newest" also to models.RenderUserSearch()

[daviian]

@Morlinest you are right @kaz has to add newest to models.RenderUserSearch() as well. Regarding the impact on the other search pages: it is fine more me, since sorting org and users by newest isn't that useful anyway, so doesn't hurt. But I have to add that we should change org and user searching to be alphabetically by default (will create separate issue for that).

[kaz]

I made some changes.

• Fix some problems which @Morlinest pointed out
• Set ctx.Data["SortType"] in default clause
  • to use different sort order in repos/users/orgs page with same template
• Change default sorting of user/org search to alphabetical (Change default sorting of user/org search to alphabetical #2656)

This changes affects pages below:

page	order(old)	order(new)
/explore/repos	newest	recentupdate
/explore/users	newest	alphabetically
/explore/organizations	newest	alphabetically
/{user_name} (repositories tab)	newest	recentupdate
/{user_name} (stars tab)	newest	recentupdate

[daviian]

Tested and approved again after new changes 👍

[lafriks]

Make LG-TM work again