Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add language search support in notification watching page #26506

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add language search support in notification watching page #26506

wants to merge 1 commit into from

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Aug 15, 2023 •
edited
Loading

Mentioned #26425 (comment)

After:
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 15, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 15, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 15, 2023
@lunny
Copy link
Member

lunny commented Aug 15, 2023 •
edited
Loading

But how to remove the filter from UI? Maybe you can get some ideas from #24212

@yp05327
Copy link
Contributor Author

yp05327 commented Aug 16, 2023

But how to remove the filter from UI? Maybe you can get some ideas from #24212

We don't have this now, so #24212 is a solution for this which doesn't related to this PR.

@lunny
Copy link
Member

lunny commented Jan 25, 2024

So this can be replaced by #24212 ?

@yp05327
Copy link
Contributor Author

yp05327 commented Jan 26, 2024

emmm, it can be added in #24212. But #24212 is broken now. Any plan to fix it?

@yp05327
Copy link
Contributor Author

yp05327 commented Feb 22, 2024

Let's wait #29044, then finish or close this one.

@yp05327 yp05327 marked this pull request as draft February 22, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puni9869 puni9869 puni9869 approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yp05327 @lunny @puni9869 @GiteaBot