Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct minio error (#26634) #26639

Merged
merged 1 commit into from
Aug 21, 2023

Commits on Aug 21, 2023

  1. Use correct minio error (go-gitea#26634)

    Previously, `err` was defined above, checked for `err == nil` and used
    nowhere else.
    Hence, the result of `convertMinioErr` would always be `nil`.
    This leads to a NPE further down the line.
    That is not intentional, it should convert the error of the most recent
    operation, not one of its predecessors.
    
    Found through
    https://discord.com/channels/322538954119184384/322538954119184384/1143185780206993550.
    delvh authored and GiteaBot committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    8a9d1dd View commit details
    Browse the repository at this point in the history