add Upload URL to release API #26663
Conversation
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
- Resolves https://codeberg.org/forgejo/forgejo/issues/580 - Return a `upload_field` to any release API response, which points to the API URL for uploading new assets. - Adds unit test. - Adds integration testing to verify URL is returned correctly and that upload endpoint actually works
earl-warren
force-pushed
the
wip-gitea-upload-link
branch
from
c058598
to
2a8e4e2
Compare
GiteaBot
added
lgtm/need 1
services/convert/release_test.go
Outdated
| @@ -0,0 +1,29 @@ | |||
| // Copyright 2023 The Gitea Authors. All rights reserved. | |||
| // Copyright 2023 The Forgejo Authors. All rights reserved. | |||
There was a problem hiding this comment.
Hi @earl-warren please remove this line, we have given this feedback to you previously, and also is stated what new files should have in our contributing.md. This is following advice given to us from The Linux Foundation.
Many others are able to contribute to the project following the contributing.md, and we don't have // Copyright Allspice, //Copyright Blender, //Copyright ... etc.. there are literally hundreds of orgs that contribute to this project.
The project appreciates you upstreaming some of the code, however, if you aren't able to follow the contribution documentation we can't make a special exception just for you. By continuously knowingly ignoring the contributing documentation we may need to take action.
There was a problem hiding this comment.
Without wishing to comment on this particular instance, I should note that the one requirement of the MIT license is that the copyright notice is preserved. It is forbidden to remove it without permission from the author.
If the author chooses to contribute directly to Gitea under Gitea's copyright notice, that's obviously their choice. If they contribute under a different copyright notice, it is illegal to remove it as by doing so you are no longer covered by the license and are therefore violating that author's copyright by copying their code.
GiteaBot
added
lgtm/blocked
It is doubtful this file meets the necessary requirements (originality of the work) to be copyrightable. It would otherwise be problematic.
lunny
added
type/enhancement
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
* giteaofficial/main: Fix review bar misalignment (go-gitea#26711) Use "small-loading-icon" insead of "btn-octicon is-loading" (go-gitea#26710) Improve Image Diff UI (go-gitea#26696) Make issue template field template access correct template data (go-gitea#26698) add Upload URL to release API (go-gitea#26663) Add merge files files to GetCommitFileStatus (go-gitea#20515) PATCH branch-protection updates check list even when checks are disabled (go-gitea#26351) Add `member`, `collaborator`, `contributor`, and `first-time contributor` roles and tooltips (go-gitea#26658) chore(actions): support cron schedule task (go-gitea#26655)
upload_fieldto any release API response, which points to the API URL for uploading new assets.