Add eslint-plugin-vue-scoped-css
#26720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
silverwind
added
topic/code-linting
skip-changelog
wxiaoguang
reviewed
Aug 25, 2023
| @@ -676,22 +671,6 @@ export function initRepositoryActionView() { | |||
|
|
|||
| /* selectors here are intentionally exact to only match fullscreen */ | |||
|
|
|||
| .full.height > .action-view-right { | |||
There was a problem hiding this comment.
I also ever questioned about this 😂
Glad to see they are moved to a global scope.
There was a problem hiding this comment.
Yes I was surprised it even worked, but apparently "scoped" style in Vue only means the final part of the selector needs to be local to the component, not the whole selector.
Pretty bad decision from Vue authors imho to not scope it completely to the component.
wxiaoguang
reviewed
Aug 25, 2023
wxiaoguang
approved these changes
Aug 25, 2023
GiteaBot
added
lgtm/need 1
puni9869
approved these changes
Aug 25, 2023
GiteaBot
added
lgtm/done
|
let's ship this pr🚀 |
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 27, 2023
* upstream/main: Move `modules/mirror` to `services` (go-gitea#26737) [skip ci] Updated translations via Crowdin Fix template bugs in recently_pushed_new_branches.tmpl (go-gitea#26744) Fix incorrect "tabindex" attributes (go-gitea#26733) Simplify helper CSS classes and avoid abuse (go-gitea#26728) Remove fomantic loader module (go-gitea#26670) Fix link in mirror docs (go-gitea#26719) Add `eslint-plugin-vue-scoped-css` (go-gitea#26720) Fixed text overflow in dropdown menu (go-gitea#26694) Make web context initialize correctly for different cases (go-gitea#26726) Remove incorrect CSS helper classes (go-gitea#26712) Focus editor on "Write" tab click (go-gitea#26714)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds eslint-plugin-vue-scoped-css and fixes discovered issues which are:
.full.heightparent in a<style scoped>block so the rule could not find the parent. Move these into the unscoped block instead. They worked before and after.