Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fomantic item module #26775

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Remove fomantic item module #26775

merged 5 commits into from
Aug 29, 2023

Conversation

silverwind
Copy link
Member

All selectors had .ui.items prefix and I did not find it in any of the templates or JS, so this is a pretty safe removal.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 28, 2023
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 28, 2023
@silverwind silverwind added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Aug 28, 2023
@silverwind silverwind changed the title Remove fomantic items module Remove fomantic item module Aug 28, 2023
delvh
delvh approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I can't find an 'items' class anywhere either, so I agree with your assessment.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 28, 2023
@delvh delvh mentioned this pull request Aug 28, 2023
Merged
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 29, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 29, 2023
@lunny lunny enabled auto-merge (squash) August 29, 2023 01:35
@delvh
Copy link
Member

delvh commented Aug 29, 2023

@GiteaBot ?

@wxiaoguang wxiaoguang enabled auto-merge (squash) August 29, 2023 07:45
@wxiaoguang
Copy link
Contributor

Maybe it's affected by GitHub's bug (GitHub slowed down for quite a while)

@wxiaoguang wxiaoguang merged commit db09b35 into go-gitea:main Aug 29, 2023
24 checks passed
@GiteaBot GiteaBot added this to the 1.21.0 milestone Aug 29, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 29, 2023
@silverwind silverwind deleted the rmitems branch August 29, 2023 14:13
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 30, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
91a5317 
* giteaofficial/main:
  Use `Set[Type]` instead of `map[Type]bool/struct{}`. (go-gitea#26804)
  Fix verifyCommits error when push a new branch (go-gitea#26664)
  Fix Uint8Array comparisons and update vitest (go-gitea#26805)
  Add various missing files-changed dependencies (go-gitea#26799)
  Improve flex list item padding (go-gitea#26779)
  Include the GITHUB_TOKEN/GITEA_TOKEN secret for fork pull requests (go-gitea#26759)
  feat(API): add route and implementation for creating/updating repository secret (go-gitea#26766)
  Replace deprecated `elliptic.Marshal` (go-gitea#26800)
  Updating the js libraries to latest version. (go-gitea#26795)
  Fix some slice append usages (go-gitea#26778)
  Use Go 1.21 for golangci-lint (go-gitea#26786)
  Fix notification circle (border-radius) (go-gitea#26794)
  Fix context filter has no effect in dashboard (go-gitea#26695)
  Add default label in branch select list (go-gitea#26697)
  Remove redundant nil check in `WalkGitLog` (go-gitea#26773)
  Remove fomantic `item` module (go-gitea#26775)
  Update info regarding internet connection for build (go-gitea#26776)
  Fix being unable to use a repo that prohibits accepting PRs as a PR source. (go-gitea#26785)
silverwind pushed a commit that referenced this pull request Aug 30, 2023
@delvh
Remove fomantic text module (#26777)
2590707 
Corollary to #26775:
All selectors I found that are actually used and not necessarily present
in the current code have been copied to `web_src/css/base.css`.
Everything else should be a clean removal.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @delvh @wxiaoguang @lunny @GiteaBot