Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase queue length #27555

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Increase queue length #27555

merged 2 commits into from
Oct 10, 2023

Conversation

wolfogre
Copy link
Member

@wolfogre wolfogre commented Oct 10, 2023

It should be OK to increase the default queue length since the default type is "level".

IMO, the old default length (100) is a little too small. See #27540 (comment)

IIRC, a larger length could lead to more memory usage only when the type is "channel," but it's an obscure case. Otherwise, it's just a limit (for "level" or "redis").

@wolfogre wolfogre added type/enhancement An improvement of existing functionality backport/v1.21 This PR should be backported to Gitea 1.21 labels Oct 10, 2023
@wolfogre wolfogre added this to the 1.22.0 milestone Oct 10, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 10, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 10, 2023
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 10, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 10, 2023
@lunny lunny merged commit 2c7b6c3 into go-gitea:main Oct 10, 2023
25 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 10, 2023
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Oct 10, 2023
silverwind pushed a commit that referenced this pull request Oct 10, 2023
Backport #27555 by @wolfogre

It should be OK to increase the default queue length since the default
type is "level".

IMO, the old default length (100) is a little too small. See
#27540 (comment)

IIRC, a larger length could lead to more memory usage only when the type
is "channel," but it's an obscure case. Otherwise, it's just a limit
(for "level" or "redis").

Co-authored-by: Jason Song <i@wolfogre.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 11, 2023
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix attachment download bug (go-gitea#27486)
  Make actions default enabled for newly created repository if global configuraion enabled (go-gitea#27482)
  Fix the wrong HTTP response status code for duplicate packages (go-gitea#27480)
  Increase queue length (go-gitea#27555)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants