Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors on BSD (in BSDMakefile) #27594

Merged
merged 2 commits into from
Oct 13, 2023

Commits on Oct 12, 2023

  1. Fix build errors on BSD

    1. `make build` fails because `||` and `&&` have the same precedence in
       sh/bash, so the `false` command always evaluated (leading to an error).
    
       ```
       + which gmake
       /usr/local/bin/gmake
       + false
    
       *** Failed target:  .BEGIN
       *** Failed command: which "gmake" || printf "Error: GNU Make is required!\n\n" 1>&2 && false
       *** Error code 1
       ```
    
    2. When `GPREFIX` is set to an empty string with quotation marks, `gmake`
       mistakenly thinks that it's a file name:
    
       ```
       gmake: *** empty string invalid as file name.  Stop.
       ```
    sryze committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    facfba5 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Configuration menu
    Copy the full SHA
    56a556f View commit details
    Browse the repository at this point in the history