Show placeholder email in privacy popup #27770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
silverwind
approved these changes
Oct 24, 2023
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Oct 25, 2023
| @@ -73,7 +73,7 @@ | |||
|
|
|||
| <div class="field"> | |||
| <div class="ui checkbox"> | |||
| <label data-tooltip-content="{{ctx.Locale.Tr "settings.keep_email_private_popup"}}"><strong>{{ctx.Locale.Tr "settings.keep_email_private"}}</strong></label> | |||
| <label data-tooltip-content="{{ctx.Locale.Tr "settings.keep_email_private_popup" .SignedUser.GetPlaceholderEmail}}"><strong>{{ctx.Locale.Tr "settings.keep_email_private"}}</strong></label> | |||
There was a problem hiding this comment.
"Use username@noreply.domain in commits to associate them with your account."
Does it really work this way? I am not sure it really works, this is a fake email address, I can't figure out how it could "associate"
There was a problem hiding this comment.
Here is the mapping of the noreply address to the account:
Line 1132 in e544a27
Although it's ugly that it does not use the GetPlaceholderEmail, it works. I tried it in my commit for act runner:
https://gitea.com/hakito/act_runner/commit/f21bc49bd2d81be3ca47ca5b6210a4b05f46e073
wxiaoguang
approved these changes
Oct 25, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
|
@hakito please fix the merge conflicts. 🍵 |
GiteaBot
removed
the
reviewed/wait-merge
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 25, 2023
* giteaoffical/main: Fix issue not showing on default board and add test (go-gitea#27720) Show placeholder email in privacy popup (go-gitea#27770) Add word-break to organization name and description (go-gitea#26624) Add border to file tree 'sub-items' and add padding to 'item-file' (go-gitea#27593) Fix the missing repo count in new team page and edit team page (go-gitea#27743) Only show diff file tree when more than one file changed (go-gitea#27775) Add gap between diff boxes (go-gitea#27776)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
This PR will show the _noreply_ address in the privacy popup _keep_email_private_popup_. I had to look into the source code to figure out which E-Mail Adress I had to use on gitea.com to hide it from public access. According to the contribution guidelines I only updated the en-US translation file. Co-authored-by: Hakito <hakito@git.example.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will show the noreply address in the privacy popup keep_email_private_popup.
I had to look into the source code to figure out which E-Mail Adress I had to use on gitea.com to hide it from public access.
According to the contribution guidelines I only updated the en-US translation file.