-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support storage base path as prefix #27827
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Oct 29, 2023
pull-request-size
bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Oct 29, 2023
wolfogre
approved these changes
Oct 30, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Oct 30, 2023
Zettat123
approved these changes
Nov 1, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Nov 1, 2023
lunny
added
pr/breaking
Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it!
and removed
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
labels
Nov 1, 2023
GiteaBot
added
the
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
label
Nov 1, 2023
lunny
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Nov 1, 2023
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Nov 1, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 2, 2023
* giteaofficial/main: Filter inactive auth sources (go-gitea#27870) refactor postgres connection string building (go-gitea#27723) doc: actions/act-runner: document running as a systemd service (go-gitea#27844) Support storage base path as prefix (go-gitea#27827)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
This PR adds a prefix path for all minio storage and override base path will override the path. The previous behavior is undefined officially, so it will be marked as breaking.
@lunny could you please add a paragraph as to how the behavior changed, and what affected users need to do? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
pr/breaking
Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it!
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
type/enhancement
An improvement of existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a prefix path for all minio storage and override base path will override the path.
The previous behavior is undefined officially, so it will be marked as breaking.
Breakage:
This PR will affect all configurations having
base_path
onstorage
section but having nobase_path
on derived storage configuration sections. Thebase_path
onstorage
will become a prefix for them but not share the same base_path.