-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add word-break to repo description in home page #27924
Merged
silverwind
merged 3 commits into
go-gitea:main
from
yp05327:add-word-break-to-repo-description-in-home-page
Nov 7, 2023
Merged
Add word-break to repo description in home page #27924
silverwind
merged 3 commits into
go-gitea:main
from
yp05327:add-word-break-to-repo-description-in-home-page
Nov 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Nov 6, 2023
pull-request-size
bot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Nov 6, 2023
delvh
approved these changes
Nov 6, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Nov 6, 2023
silverwind
reviewed
Nov 7, 2023
pull-request-size
bot
added
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Nov 7, 2023
silverwind
approved these changes
Nov 7, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Nov 7, 2023
silverwind
added
backport/v1.21
This PR should be backported to Gitea 1.21
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
labels
Nov 7, 2023
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Nov 7, 2023
In go-gitea#25315, @denyskon fixed UI on mobile view. But for the repo description, on desktop view there's no word-break. So maybe we can just add `gt-word-break` to fix it on both mobile view and desktop view. Before: desktop view: ![image](https://github.com/go-gitea/gitea/assets/18380374/a7659f5b-fbe9-400a-8cc2-cca44778556e) mobile view: ![image](https://github.com/go-gitea/gitea/assets/18380374/611f1b81-58ac-4213-b165-5c73e24ca79e) After: desktop view: ![image](https://github.com/go-gitea/gitea/assets/18380374/f21bf3a7-f6aa-457d-9bfa-5c57659c68b1) mobile view(almost same?) ![image](https://github.com/go-gitea/gitea/assets/18380374/ad2d1a4d-1172-402c-b5fc-5e910657847d) --------- Co-authored-by: silverwind <me@silverwind.io>
GiteaBot
added
backport/done
All backports for this PR have been created
and removed
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
labels
Nov 7, 2023
silverwind
added a commit
that referenced
this pull request
Nov 8, 2023
Backport #27924 by @yp05327 In #25315, @denyskon fixed UI on mobile view. But for the repo description, on desktop view there's no word-break. So maybe we can just add `gt-word-break` to fix it on both mobile view and desktop view. Before: desktop view: ![image](https://github.com/go-gitea/gitea/assets/18380374/a7659f5b-fbe9-400a-8cc2-cca44778556e) mobile view: ![image](https://github.com/go-gitea/gitea/assets/18380374/611f1b81-58ac-4213-b165-5c73e24ca79e) After: desktop view: ![image](https://github.com/go-gitea/gitea/assets/18380374/f21bf3a7-f6aa-457d-9bfa-5c57659c68b1) mobile view(almost same?) ![image](https://github.com/go-gitea/gitea/assets/18380374/ad2d1a4d-1172-402c-b5fc-5e910657847d) Co-authored-by: yp05327 <576951401@qq.com> Co-authored-by: silverwind <me@silverwind.io>
yp05327
added a commit
to yp05327/gitea
that referenced
this pull request
Nov 8, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 8, 2023
* giteaofficial/main: Fix citation error when the file size is larger than 1024 bytes (go-gitea#27958) Use flex-container on user dashboard (go-gitea#27956) Document REACTION_MAX_USER_NUM setting option (go-gitea#27954) Add word-break to repo description in home page (go-gitea#27924) Remove go versions from .golangci.yml (go-gitea#27953) Fix the overflow style for "Hide all checks" (go-gitea#27932) Fix rendering assignee changed comments without assignee (go-gitea#27927) Add word break to release title (go-gitea#27942)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
In go-gitea#25315, @denyskon fixed UI on mobile view. But for the repo description, on desktop view there's no word-break. So maybe we can just add `gt-word-break` to fix it on both mobile view and desktop view. Before: desktop view: ![image](https://github.com/go-gitea/gitea/assets/18380374/a7659f5b-fbe9-400a-8cc2-cca44778556e) mobile view: ![image](https://github.com/go-gitea/gitea/assets/18380374/611f1b81-58ac-4213-b165-5c73e24ca79e) After: desktop view: ![image](https://github.com/go-gitea/gitea/assets/18380374/f21bf3a7-f6aa-457d-9bfa-5c57659c68b1) mobile view(almost same?) ![image](https://github.com/go-gitea/gitea/assets/18380374/ad2d1a4d-1172-402c-b5fc-5e910657847d) --------- Co-authored-by: silverwind <me@silverwind.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
backport/v1.21
This PR should be backported to Gitea 1.21
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
topic/ui
Change the appearance of the Gitea UI
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #25315, @denyskon fixed UI on mobile view.
But for the repo description, on desktop view there's no word-break.
So maybe we can just add
gt-word-break
to fix it on both mobile view and desktop view.Before:
desktop view:
mobile view:
After:
desktop view:
mobile view(almost same?)