Add Profile Readme for Organisations #27955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
added
type/feature
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
KN4CK3R
reviewed
Nov 7, 2023
silverwind
reviewed
Nov 7, 2023
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
silverwind
reviewed
Nov 9, 2023
silverwind
approved these changes
Nov 9, 2023
GiteaBot
added
lgtm/need 1
|
Is it really a good design to put the "readme" there? If the "readme" content is short, then the "org descrption" does the same thing, is the "readme" content just redundancy? If the "readme" content is long, then it takes a lot of space of the "org home" page, then the "search input" and the "list" position/layout is quite strange. Indeed, the "org home page" is not the same as "user profile page". |
|
Here is an example from Github: https://github.com/react-native-elements |
|
So GitHub Readmes are in special repo |
Is GitHub always right? (I don't mean to block, just curious, feel free to ignore my question) |
lafriks
approved these changes
Nov 9, 2023
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 10, 2023
* giteaofficial/main: Remove `title` from elements on Org mode (go-gitea#27968) Add Profile Readme for Organisations (go-gitea#27955) Allow to set explore page default sort (go-gitea#27951)
6543
pushed a commit
that referenced
this pull request
Nov 13, 2023
Fixes some problems in #27955: - autofocus of the search box before: if access the home page will jump to the search box  after: will not jump to the search box  - incorrect display of overview tab before:  after:  - improve the permission check to the private profile repo In #26295, we simply added access control to the private profile. But if user have access to the private profile repo , we should also display the profile. - add a button which can jump to the repo list? I agree @wxiaoguang 's opinion here: #27955 (comment) But it seems that this feature is sponsored. So can we add a button which can quickly jump to the repo list or just move profile to the `overview` page? --------- Co-authored-by: silverwind <me@silverwind.io>
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
https://blog.gitea.com/release-of-1.20.0/#-user-profile-readme-23260 (go-gitea#23260) did introduce Profile Readme for Users. This makes it usable for Organisations:  --- *Sponsored by Kithara Software GmbH* --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
Fixes some problems in go-gitea#27955: - autofocus of the search box before: if access the home page will jump to the search box  after: will not jump to the search box  - incorrect display of overview tab before:  after:  - improve the permission check to the private profile repo In go-gitea#26295, we simply added access control to the private profile. But if user have access to the private profile repo , we should also display the profile. - add a button which can jump to the repo list? I agree @wxiaoguang 's opinion here: go-gitea#27955 (comment) But it seems that this feature is sponsored. So can we add a button which can quickly jump to the repo list or just move profile to the `overview` page? --------- Co-authored-by: silverwind <me@silverwind.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://blog.gitea.com/release-of-1.20.0/#-user-profile-readme-23260 (#23260) did introduce Profile Readme for Users.
This makes it usable for Organisations:
Sponsored by Kithara Software GmbH