Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added instance-level variables #28115

Merged
merged 3 commits into from
Dec 25, 2023
Merged

Added instance-level variables #28115

merged 3 commits into from
Dec 25, 2023

Conversation

jbgomond
Copy link
Contributor

@jbgomond jbgomond commented Nov 18, 2023 •
edited by lunny
Loading

This PR adds instance-level variables, and so closes #27726

gitea_instance_variables_1
gitea_instance_variables_2
gitea_instance_variables_3

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 18, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 18, 2023
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Nov 18, 2023
@lunny lunny added the type/enhancement An improvement of existing functionality label Nov 20, 2023
@lunny lunny added this to the 1.22.0 milestone Nov 20, 2023
@jbgomond
Copy link
Contributor Author

Hi, is it good to be merged ? :)

@lunny lunny added the topic/gitea-actions related to the actions of Gitea label Dec 12, 2023
@wolfogre
Copy link
Member

Could you please provide some screenshots?

@jbgomond
Copy link
Contributor Author

jbgomond commented Dec 17, 2023 •
edited
Loading

Yes, here are the screenshots :

gitea_instance_variables_1
gitea_instance_variables_2
gitea_instance_variables_3

wolfogre
wolfogre approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@wolfogre wolfogre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 18, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 18, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 18, 2023
@lunny lunny enabled auto-merge (squash) December 18, 2023 07:32
auto-merge was automatically disabled December 23, 2023 23:04

Head branch was pushed to by a user without write access

@jbgomond jbgomond force-pushed the feature/instance-variables branch from 5c4b3af to 34f3ca6 Compare December 23, 2023 23:04
@jbgomond jbgomond force-pushed the feature/instance-variables branch from 34f3ca6 to 3992898 Compare December 24, 2023 00:40
@jbgomond
Copy link
Contributor Author

@lunny I updated branch against main :)

@lunny lunny enabled auto-merge (squash) December 25, 2023 06:53
@lunny lunny merged commit d0f24ff into go-gitea:main Dec 25, 2023
25 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 25, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 25, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
a548fe7 
* giteaofficial/main:
  Added instance-level variables (go-gitea#28115)
  Revert "improve possible performance bottleneck (go-gitea#28547)" (go-gitea#28593)
  [skip ci] Updated licenses and gitignores
  Fix flex container width (go-gitea#28603)
  Fix the scroll behavior for emoji/mention list (go-gitea#28597)
  bump to use alpine3.19 (go-gitea#28594)
  Include heap pprof in diagnosis report to help debugging memory leaks (go-gitea#28596)
  Disable query token param in integration tests (go-gitea#28592)
  Fix wrong due date rendering in issue list page (go-gitea#28588)
  Fix `status_check_contexts` matching bug (go-gitea#28582)
  Fix 405 method not allowed CORS / OIDC (go-gitea#28583)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@jbgomond @fuxiaohei
Added instance-level variables (go-gitea#28115)
9d34a0e 
This PR adds instance-level variables, and so closes go-gitea#27726



![gitea_instance_variables_1](https://github.com/go-gitea/gitea/assets/8344487/ad409cd4-ce36-4c84-a764-34451b0fb63a)

![gitea_instance_variables_2](https://github.com/go-gitea/gitea/assets/8344487/426f0965-dec6-4560-948c-067cdeddd720)

![gitea_instance_variables_3](https://github.com/go-gitea/gitea/assets/8344487/cf1d7776-4938-4825-922e-cbbbf28a5f33)
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@jbgomond @silverwind
Added instance-level variables (go-gitea#28115)
8a4f1b6 
This PR adds instance-level variables, and so closes go-gitea#27726



![gitea_instance_variables_1](https://github.com/go-gitea/gitea/assets/8344487/ad409cd4-ce36-4c84-a764-34451b0fb63a)

![gitea_instance_variables_2](https://github.com/go-gitea/gitea/assets/8344487/426f0965-dec6-4560-948c-067cdeddd720)

![gitea_instance_variables_3](https://github.com/go-gitea/gitea/assets/8344487/cf1d7776-4938-4825-922e-cbbbf28a5f33)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sillyguodong sillyguodong sillyguodong approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/gitea-actions related to the actions of Gitea type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Instance-level action variables
5 participants
@jbgomond @wolfogre @sillyguodong @lunny @GiteaBot