Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render PyPi long description as document #28272

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

earl-warren
Copy link
Contributor

  • PyPi long descriptions supports markdown and are rendered as such in Forgejo, however it uses RenderMarkdownToHtml function, which would render all newlines literally causing that lines seperated by newlines aren't rendered as a continues line.
  • Add a new helper function that renders markdown as a document and use it for PyPi's long description.
  • Resolves https://codeberg.org/forgejo/forgejo/issues/1784

(cherry picked from commit feaebc15793a9c74713e40c478872e3709dc09b6)

- PyPi long descriptions supports markdown and are rendered as such in
Forgejo, however it uses `RenderMarkdownToHtml` function, which would
render all newlines literally causing that lines seperated by newlines
aren't rendered as a continues line.
- Add a new helper function that renders markdown as a document and use
it for PyPi's long description.
- Resolves https://codeberg.org/forgejo/forgejo/issues/1784

(cherry picked from commit feaebc15793a9c74713e40c478872e3709dc09b6)
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 28, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 28, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 30, 2023
@KN4CK3R
Copy link
Member

KN4CK3R commented Nov 30, 2023

I think it would be better to just change the existing RenderMarkdownToHtml. I added this method with the package PR and the "document rendering" is what it should be for all package related markdown code. From a first view, it should not affect the three new calls of that method in other places.

@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 4, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 5, 2023
@jolheiser jolheiser enabled auto-merge (squash) December 5, 2023 14:35
@jolheiser jolheiser added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 5, 2023
@jolheiser jolheiser merged commit 876a0cb into go-gitea:main Dec 5, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Dec 5, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 5, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 6, 2023
* giteaofficial/main:
  Fix the runs will not be displayed bug when the main branch have no workflows but other branches have (go-gitea#28359)
  [skip ci] Updated translations via Crowdin
  Render PyPi long description as document (go-gitea#28272)
  handle repository.size column being NULL in migration v263 (go-gitea#28336)
  Fix migration panic due to an empty review comment diff (go-gitea#28334)
  Add `HEAD` support for rpm repo files (go-gitea#28309)
  Remove deprecated query condition in ListReleases (go-gitea#28339)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
Co-authored-by: Gusted <postmaster@gusted.xyz>
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
Co-authored-by: Gusted <postmaster@gusted.xyz>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants