Fix RPM/Debian signature key creation #28352
Conversation
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
GiteaBot
added
lgtm/need 1
|
It seems like ideally this would have something set, but is there a more predictable setting we could use? I don't know much about RPM/Debian or where this signature is used/shown, so maybe it's of no consequence, but it seems like a full signature would be ideal if possible. |
|
I thought about using the owner name here but I don't think you "see" this key somewhere. It's only used to check the repository files for consistency. Email was already empty, therefore I removed the name too. |
Changing this doesn't cause breakage, then? |
|
Only new generated keys are affected. Once generated the key is stored as a user setting. |
Ah, right, packages are user/org level. In that case maybe the owner name would be good for this like you said. I think this is tentatively lgtm, but I would like if someone more familiar with debian packages could confirm whether it's the right strategy here. |
|
In my mind exists a page where you can provide your own key-pair instead of generating one. Then you could reuse an existing key. If you don't need that, a generated key is fine. The docs don't specify what info a key should contain:
|
techknowlogick
added
the
backport/v1.21
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
Fixes go-gitea#28324 The name parameter can't contain some characters (https://github.com/keybase/go-crypto/blob/master/openpgp/keys.go#L680) but is optional. Therefore just use an empty string.
GiteaBot
added
backport/done
Fixes go-gitea#28324 The name parameter can't contain some characters (https://github.com/keybase/go-crypto/blob/master/openpgp/keys.go#L680) but is optional. Therefore just use an empty string.
Backport #28352 by @KN4CK3R Fixes #28324 The name parameter can't contain some characters (https://github.com/keybase/go-crypto/blob/master/openpgp/keys.go#L680) but is optional. Therefore just use an empty string. Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
* giteaofficial/main: Convert git commit summary to valid UTF8. (go-gitea#28356) Fix RPM/Debian signature key creation (go-gitea#28352) Refactor template empty checks (go-gitea#28351)
|
It would be nice to have an ENV to change the value of the key. |
Fixes go-gitea#28324 The name parameter can't contain some characters (https://github.com/keybase/go-crypto/blob/master/openpgp/keys.go#L680) but is optional. Therefore just use an empty string.
Fixes go-gitea#28324 The name parameter can't contain some characters (https://github.com/keybase/go-crypto/blob/master/openpgp/keys.go#L680) but is optional. Therefore just use an empty string.
Fixes #28324
The name parameter can't contain some characters (https://github.com/keybase/go-crypto/blob/master/openpgp/keys.go#L680) but is optional. Therefore just use an empty string.