Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle repository.size column being NULL in migration v263 (#28336) #28363

Merged
merged 1 commit into from
Dec 5, 2023

Commits on Dec 5, 2023

  1. handle repository.size column being NULL in migration v263 (go-gitea#…

    …28336)
    
    This resolves a problem I encountered while updating gitea from 1.20.4
    to 1.21. For some reason (correct or otherwise) there are some values in
    `repository.size` that are NULL in my gitea database which cause this
    migration to fail due to the NOT NULL constraints.
    
    Log snippet (excuse the escape characters)
    ```
    ESC[36mgitea                |ESC[0m 2023-12-04T03:52:28.573122395Z 2023/12/04 03:52:28 ...ations/migrations.go:641:Migrate() [I] Migration[263]: Add git_size and lfs_size columns to repository table
    ESC[36mgitea                |ESC[0m 2023-12-04T03:52:28.608705544Z 2023/12/04 03:52:28 routers/common/db.go:36:InitDBEngine() [E] ORM engine initialization attempt go-gitea#3/10 failed. Error: migrate: migration[263]: Add git_size and lfs_size columns to repository table failed: NOT NULL constraint failed: repository.git_size
    ```
    
    I assume this should be reasonably safe since `repository.git_size` has
    a default value of 0 but I don't know if that value being 0 in the odd
    situation where `repository.size == NULL` has any problematic
    consequences.
    thenaterhood authored and GiteaBot committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    aa491b0 View commit details
    Browse the repository at this point in the history