Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do some missing checks #28423

Merged
merged 15 commits into from
Dec 12, 2023
Merged

Do some missing checks #28423

merged 15 commits into from
Dec 12, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 11, 2023

No description provided.

@lunny lunny added the type/bug label Dec 11, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 11, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 11, 2023
@lunny lunny requested a review from wolfogre December 11, 2023 13:32
@lunny lunny added backport/v1.20 This PR should be backported to Gitea 1.20 backport/v1.21 This PR should be backported to Gitea 1.21 labels Dec 11, 2023
@lunny lunny added this to the 1.22.0 milestone Dec 11, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 11, 2023
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 12, 2023
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Dec 12, 2023
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 12, 2023
@lunny lunny enabled auto-merge (squash) December 12, 2023 05:00
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 12, 2023
@lunny lunny merged commit 717d0f5 into go-gitea:main Dec 12, 2023
25 checks passed
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.21. @lunny, please send one manually. 🍵

go run ./contrib/backport 28423
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Dec 12, 2023
@lunny lunny deleted the lunny/fix_private_user_project branch December 12, 2023 05:05
lunny added a commit to lunny/gitea that referenced this pull request Dec 12, 2023
@lunny
Do some missing checks (go-gitea#28423)
6741d89
@lunny lunny mentioned this pull request Dec 12, 2023
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Dec 12, 2023
lunny added a commit that referenced this pull request Dec 12, 2023
@lunny
Do some missing checks (#28423) (#28432)
265f485 
backport #28423
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 13, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
b4a4443 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix possible nil pointer access (go-gitea#28428)
  Don't show unnecessary citation JS error on UI (go-gitea#28433)
  Do some missing checks (go-gitea#28423)
  Deprecate query string auth tokens (go-gitea#28390)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@lunny @fuxiaohei
Do some missing checks (go-gitea#28423)
f42ab27
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@lunny @silverwind
Do some missing checks (go-gitea#28423)
4f48b9d
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.20 This PR should be backported to Gitea 1.20 backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @GiteaBot @wxiaoguang @wolfogre