Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve doctor cli behavior (#28422) #28424

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Improve doctor cli behavior (#28422) #28424

merged 1 commit into from
Dec 11, 2023

Conversation

GiteaBot
Copy link
Contributor

Backport #28422 by @wxiaoguang

  1. Do not sort the "checks" slice again and again when "Register", it just wastes CPU when the Gitea instance runs
  2. If a check doesn't exist, tell the end user
  3. Add some tests

@wxiaoguang @GiteaBot
Improve doctor cli behavior (go-gitea#28422)
dbec223 
1. Do not sort the "checks" slice again and again when "Register", it
just wastes CPU when the Gitea instance runs
2. If a check doesn't exist, tell the end user
3. Add some tests
@GiteaBot GiteaBot added modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin type/enhancement An improvement of existing functionality labels Dec 11, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 11, 2023
@GiteaBot GiteaBot added this to the 1.21.2 milestone Dec 11, 2023
@GiteaBot GiteaBot requested review from delvh and lunny December 11, 2023 15:55
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 11, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 11, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2023
@wxiaoguang wxiaoguang enabled auto-merge (squash) December 11, 2023 16:15
@wxiaoguang wxiaoguang merged commit 1ec622d into go-gitea:release/v1.21 Dec 11, 2023
26 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

@delvh delvh Awaiting requested review from delvh

Assignees

@wxiaoguang wxiaoguang

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.21.2
Development

Successfully merging this pull request may close these issues.
3 participants
@GiteaBot @lunny @wxiaoguang