Improve 404 screen on mobile #28710
Closed
Improve 404 screen on mobile #28710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `container` to remove unnecessary margins being added to the whole page. - Specify max width for the 404 image to avoid overflow of the image. Refs: https://codeberg.org/forgejo/forgejo/pulls/2101 (cherry picked from commit 2235c227402c7b1b6e2d4c77215fa15d636f25c7)
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
github-actions
bot
added
the
modifies/templates
delvh
approved these changes
Jan 6, 2024
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Jan 6, 2024
| @@ -1,8 +1,8 @@ | |||
| {{template "base/head" .}} | |||
| <div role="main" aria-label="{{.Title}}" class="page-content ui container center gt-w-screen {{if .IsRepo}}repository{{end}}"> | |||
| <div role="main" aria-label="{{.Title}}" class="page-content ui center gt-w-screen {{if .IsRepo}}repository{{end}}"> | |||
There was a problem hiding this comment.
Does ui or center make sense here? The gt-w-screen seems a no-op here too.
Maybe it should be: class="page-content {{if .IsRepo}}repository{{end}}"
wxiaoguang
reviewed
Jan 6, 2024
| {{if .IsRepo}}{{template "repo/header" .}}{{end}} | ||
| <div class="ui container center"> | ||
| <p style="margin-top: 100px"><img src="{{AssetUrlPrefix}}/img/404.png" alt="404"></p> | ||
| <p style="margin-top: 100px"><img src="{{AssetUrlPrefix}}/img/404.png" alt="404" style="max-width: 100%"></p> |
There was a problem hiding this comment.
It seems that there are already some good-enough helpers for this case.
Maybe it should be: <img class="gt-mt-5 gt-max-w-full" src="{{AssetUrlPrefix}}/img/404.png" alt="404"> (maybe it needs a new helper class max-w-full as tailwind style)
(Although "avoiding inline styles as much as possible" hasn't been written into guideline yet, it has been a consensus for long time during reviewing.)
|
Could you provide a screenshot of what this looks like on mobile? |
|
-> Fix some pending problems #29985 |
wxiaoguang
added a commit
that referenced
this pull request
Mar 22, 2024
These changes are quite independent and trivial, so I don't want to open too many PRs. * #29882 (comment) * the `f.Close` should be called properly * the error message could be more meaningful (#29882 (review)) * #29859 (review) * the new translation strings don't take arguments * #28710 (comment) * stale for long time * #28140 * a form was forgotten to be changed to work with backend code
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Mar 26, 2024
These changes are quite independent and trivial, so I don't want to open too many PRs. * go-gitea/gitea#29882 (comment) * the `f.Close` should be called properly * the error message could be more meaningful (go-gitea/gitea#29882 (review)) * go-gitea/gitea#29859 (review) * the new translation strings don't take arguments * go-gitea/gitea#28710 (comment) * stale for long time * #28140 * a form was forgotten to be changed to work with backend code (cherry picked from commit 226231ea27d4f2b0f09fa4efb39501507613b284) Conflicts: templates/repo/issue/view_content/pull.tmpl discarded because unexplained templates/status/404.tmpl implemented differently in Forgejo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
containerto remove unnecessary margins being added to the whole page.Refs: https://codeberg.org/forgejo/forgejo/pulls/2101
(cherry picked from commit 2235c227402c7b1b6e2d4c77215fa15d636f25c7)