Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display latest sync time for pull mirrors on the repo page #28712

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Display latest sync time for pull mirrors on the repo page #28712

merged 4 commits into from
Jan 15, 2024

Conversation

dsseng
Copy link
Contributor

@dsseng dsseng commented Jan 6, 2024

Fixes #25168

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 6, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 6, 2024
@github-actions github-actions bot added modifies/translation modifies/api This PR adds API routes or modifies them modifies/migrations labels Jan 6, 2024
dsseng
dsseng commented Jan 6, 2024
View reviewed changes
models/repo/repo.go Outdated Show resolved Hide resolved
@techknowlogick
Copy link
Member

Could you provide a screenshot?

delvh
delvh previously requested changes Jan 6, 2024
View reviewed changes
templates/repo/header.tmpl Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 6, 2024
@dsseng
Copy link
Contributor Author

dsseng commented Jan 7, 2024

Screenshots:

image
image

@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 13, 2024
@github-actions github-actions bot added modifies/templates This PR modifies the template files and removed modifies/translation modifies/api This PR adds API routes or modifies them modifies/migrations labels Jan 13, 2024
@dsseng dsseng requested a review from delvh January 13, 2024 15:53
@lunny
Copy link
Member

lunny commented Jan 15, 2024

Updated time maybe zero.

@delvh delvh dismissed their stale review January 15, 2024 10:13

Outdated

@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Jan 15, 2024
delvh
delvh approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after that small improvement

templates/repo/header.tmpl Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 15, 2024
@delvh
Copy link
Member

delvh commented Jan 15, 2024

@lunny please re-review

@delvh delvh added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Jan 15, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 15, 2024
@lunny lunny added this to the 1.22.0 milestone Jan 15, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 15, 2024
@lunny lunny enabled auto-merge (squash) January 15, 2024 14:12
@lunny lunny merged commit 2d343f8 into go-gitea:main Jan 15, 2024
25 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 15, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 16, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
b112684 
* giteaofficial/main: (34 commits)
  Use refname:strip-2 instead of refname:short when syncing tags (go-gitea#28797)
  Add gist to comparison (go-gitea#28809)
  Fix links in issue card (go-gitea#28806)
  Show latest commit for file (go-gitea#28067)
  Add ability to see open and closed issues at the same time (go-gitea#28757)
  Display latest sync time for pull mirrors on the repo page (go-gitea#28712)
  Fix `GetCommitStatuses` (go-gitea#28787)
  Caller should check the ResponseExtra.HasError() first to see whether the request fails (go-gitea#28796)
  Rework markup link rendering (go-gitea#26745)
  Fix nil pointer panic when exec some gitea cli command (go-gitea#28791)
  Add branch protection setting for ignoring stale approvals (go-gitea#28498)
  Forbid removing the last admin user (go-gitea#28337)
  Fix when private user following user, private user will not be counted in his own view (go-gitea#28037)
  Update github.com/cloudflare/circl (go-gitea#28789)
  Move more functions to db.Find (go-gitea#28419)
  Add non-JS fallback for reaction tooltips (go-gitea#28785)
  Modernize merge button (go-gitea#28140)
  Warn that `DISABLE_QUERY_AUTH_TOKEN` is false only if it's explicitly defined (go-gitea#28783)
  Speed up loading the dashboard on mysql/mariadb (go-gitea#28546)
  Fix schedule tasks bugs (go-gitea#28691)
  ...
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@dsseng @delvh @fuxiaohei
Display latest sync time for pull mirrors on the repo page (go-gitea#…
20a394d 
…28712)

Fixes go-gitea#25168

---------

Co-authored-by: delvh <dev.lh@web.de>
@yp05327 yp05327 mentioned this pull request Jan 18, 2024
Merged
lunny pushed a commit that referenced this pull request Jan 18, 2024
@yp05327
Fix display latest sync time for pull mirrors on the repo page (#28841)
4674aea 
Follow #28712

1. Missing Locale word `mirror_sync`
2. Maybe forgot checking the conflict from #27760

Before:

![image](https://github.com/go-gitea/gitea/assets/18380374/6100d35b-7fe3-4095-9c24-7875568f7380)

After:

![image](https://github.com/go-gitea/gitea/assets/18380374/69647169-b812-45bc-a267-ab28f2df6ef6)
henrygoodman pushed a commit to henrygoodman/gitea that referenced this pull request Jan 31, 2024
@dsseng @delvh @henrygoodman
Display latest sync time for pull mirrors on the repo page (go-gitea#…
f5269d5 
…28712)

Fixes go-gitea#25168

---------

Co-authored-by: delvh <dev.lh@web.de>
henrygoodman pushed a commit to henrygoodman/gitea that referenced this pull request Jan 31, 2024
@yp05327 @henrygoodman
Fix display latest sync time for pull mirrors on the repo page (go-gi…
08149e6 
…tea#28841)

Follow go-gitea#28712

1. Missing Locale word `mirror_sync`
2. Maybe forgot checking the conflict from go-gitea#27760

Before:

![image](https://github.com/go-gitea/gitea/assets/18380374/6100d35b-7fe3-4095-9c24-7875568f7380)

After:

![image](https://github.com/go-gitea/gitea/assets/18380374/69647169-b812-45bc-a267-ab28f2df6ef6)
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@dsseng @delvh @silverwind
Display latest sync time for pull mirrors on the repo page (go-gitea#…
ec371f4 
…28712)

Fixes go-gitea#25168

---------

Co-authored-by: delvh <dev.lh@web.de>
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@yp05327 @silverwind
Fix display latest sync time for pull mirrors on the repo page (go-gi…
8816956 
…tea#28841)

Follow go-gitea#28712

1. Missing Locale word `mirror_sync`
2. Maybe forgot checking the conflict from go-gitea#27760

Before:

![image](https://github.com/go-gitea/gitea/assets/18380374/6100d35b-7fe3-4095-9c24-7875568f7380)

After:

![image](https://github.com/go-gitea/gitea/assets/18380374/69647169-b812-45bc-a267-ab28f2df6ef6)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Mirror Synchronization status display
5 participants
@dsseng @techknowlogick @lunny @delvh @GiteaBot