Add alert blocks in markdown #29121
Merged
Add alert blocks in markdown #29121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
GiteaBot
added
the
pr/breaking
yardenshoham
added
the
type/feature
yardenshoham
force-pushed
the
issues/28316
branch
from
ef1f3a0
to
b192f9b
Compare
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
yardenshoham
force-pushed
the
issues/28316
branch
from
b192f9b
to
cc8444d
Compare
|
Would be nice to also fix the title style as the icon looks really out of order |
|
Yeah I don't know CSS it's black magic |
|
I will take look at the css tomorrow 😉 |
|
"Tip" icon not colored correctly in the screenshot. Also, icon needs vertical centering with text. Check GH CSS. |
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
|
Updated the icon vertical-align Before
After
|
yardenshoham
added
the
topic/content-rendering
|
Fixed tip color Before
After
|
lafriks
reviewed
Feb 10, 2024
|
Oof these look bad in light theme, I need better colors |
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
|
Fixed |
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
|
Added some margin-right to the icon and dropped the boldness one level Before
After
|
|
Contrast on dark theme seems a bit low for Note, Caution and Tip. Do we have better suitable variables (1 level lighter?). |
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
|
I changed Note and Caution. I think Tip will look bad on light theme if I change it Before
After
|
|
Pushed a tweak to purple, looks good enough for me on both themes: 
|
|
The problem with the tip icon is strange, I will investigate. |
|
@yardenshoham the problem is the tip icon is missing the |
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
|
Fixed |
silverwind
approved these changes
Feb 10, 2024
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Feb 10, 2024
GiteaBot
added
lgtm/done
yardenshoham
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 14, 2024
* giteaofficial/main: (38 commits) Document how the TOC election process works (go-gitea#29135) Runner tokens are multi use (go-gitea#29153) Fix Gitpod logic of setting ROOT_URL (go-gitea#29162) Remove jQuery from the user search form in admin page (go-gitea#29151) Dont load Review if Comment is CommentTypeReviewRequest (go-gitea#28551) Show `View at this point in history` for every commit (go-gitea#29122) [skip ci] Updated translations via Crowdin Add merge style `fast-forward-only` (go-gitea#28954) Use Markdown alert syntax for notes in README (go-gitea#29150) Refactor issue template parsing and fix API endpoint (go-gitea#29069) [skip ci] Updated translations via Crowdin Update some translations and fix markdown formatting (go-gitea#29099) Show more settings for empty repositories (go-gitea#29130) Update JS and PY dependencies (go-gitea#29127) Add alert blocks in markdown (go-gitea#29121) Remove obsolete border-radius on comment content (go-gitea#29128) Make blockquote border size less aggressive (go-gitea#29124) Drop "@" from email sender to avoid spam filters (go-gitea#29109) [skip ci] Updated translations via Crowdin Disallow duplicate storage paths (go-gitea#26484) ...
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
- Follows go-gitea#21711 - Closes go-gitea#28316 Implement GitHub's alert blocks markdown feature Docs: - https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts - https://github.com/orgs/community/discussions/16925 ### Before  ### After  ##⚠️ BREAKING⚠️ The old syntax no longer works How to migrate: If you used ```md > **Note** My note ``` Switch to ```md > [!NOTE] > My note ``` --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io>
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Feb 26, 2024
- Follows go-gitea#21711 - Closes go-gitea#28316 Implement GitHub's alert blocks markdown feature Docs: - https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts - https://github.com/orgs/community/discussions/16925 ### Before  ### After  ##⚠️ BREAKING⚠️ The old syntax no longer works How to migrate: If you used ```md > **Note** My note ``` Switch to ```md > [!NOTE] > My note ``` --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NoteandWarning#21711Implement GitHub's alert blocks markdown feature
Docs:
Before
After
The old syntax no longer works
How to migrate:
If you used
> **Note** My noteSwitch to