Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ghost user if user was not found #29161

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Use ghost user if user was not found #29161

merged 2 commits into from
Feb 14, 2024

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Feb 13, 2024

Fixes #29159

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 13, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 13, 2024
@KN4CK3R KN4CK3R mentioned this pull request Feb 13, 2024
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 13, 2024
delvh
delvh approved these changes Feb 13, 2024
View reviewed changes
models/issues/review.go
@@ -159,6 +159,14 @@ func (r *Review) LoadReviewer(ctx context.Context) (err error) {
return err
}
r.Reviewer, err = user_model.GetPossibleUserByID(ctx, r.ReviewerID)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optimally, these changes should be part of GetPossibleUserByID (except for setting r.ReviewerID).
However, I don't know if there are any places whose behavior would change because of this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, but it's still mixed logic like the change for the comment.Assignee which does not use GetPossibleUserByID.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 13, 2024
@KN4CK3R KN4CK3R added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 14, 2024
@KN4CK3R KN4CK3R merged commit 37061e8 into go-gitea:main Feb 14, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 14, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 14, 2024
@KN4CK3R KN4CK3R deleted the fix-missing-user branch February 14, 2024 16:32
@KN4CK3R KN4CK3R added the backport/v1.21 This PR should be backported to Gitea 1.21 label Feb 14, 2024
KN4CK3R added a commit to KN4CK3R/gitea that referenced this pull request Feb 14, 2024
@KN4CK3R
Use ghost user if user was not found (go-gitea#29161)
9eb3945 
Fixes go-gitea#29159
@KN4CK3R KN4CK3R mentioned this pull request Feb 14, 2024
Merged
techknowlogick pushed a commit that referenced this pull request Feb 14, 2024
@KN4CK3R
Use ghost user if user was not found (#29161) (#29169)
d823465 
Backport #29161
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.21. @KN4CK3R, please send one manually. 🍵

go run ./contrib/backport 29161
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Feb 14, 2024
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 15, 2024
@KN4CK3R @silverwind
Use ghost user if user was not found (go-gitea#29161)
56759a9 
Fixes go-gitea#29159
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@KN4CK3R @silverwind
Use ghost user if user was not found (go-gitea#29161)
eef317a 
Fixes go-gitea#29159
@KN4CK3R KN4CK3R added backport/done All backports for this PR have been created and removed backport/manual No power to the bots! Create your backport yourself! labels Feb 21, 2024
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Feb 26, 2024
@KN4CK3R @earl-warren
Use ghost user if user was not found (go-gitea#29161)
6eaabb1 
Fixes go-gitea#29159

(cherry picked from commit 37061e8)
@github-actions GitHub Actions
Copy link

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Pull request created by deleted user can not be opened
4 participants
@KN4CK3R @GiteaBot @silverwind @delvh