Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneccesary initUserAuthLinkAccountView from "link account" page #29217

Merged
merged 3 commits into from
Feb 17, 2024
Merged

Remove unneccesary initUserAuthLinkAccountView from "link account" page #29217

merged 3 commits into from
Feb 17, 2024

Conversation

yardenshoham
Copy link
Member

@yardenshoham yardenshoham commented Feb 17, 2024 •
edited
Loading

Deleted initUserAuthLinkAccountView

@yardenshoham
Remove jQuery from "link account" page
668492f 
- Switched to plain JavaScript

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 17, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 17, 2024
@yardenshoham
Copy link
Member Author

Not sure how to test this one, some help would appreciated

delvh
delvh approved these changes Feb 17, 2024
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good in general.
Regarding getting rid of jQuery: I think I prefer getting it merged soon and fixing potential bugs over keeping it due to uncertainty

web_src/js/features/user-auth.js Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 17, 2024
@silverwind
Copy link
Member

silverwind commented Feb 17, 2024 •
edited
Loading

Sounds good in general. Regarding getting rid of jQuery: I think I prefer getting it merged soon and fixing potential bugs over keeping it due to uncertainty

We should aim to remove all first-party jQuery, and in process turn on the related eslint rules. jQuery as a dependency will not go away until fomantic-ui is removed, which is likely still a long way to go.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 17, 2024
@yardenshoham yardenshoham added type/refactoring Existing code has been cleaned up. There should be no new functionality. reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Feb 17, 2024
@wxiaoguang wxiaoguang removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 17, 2024
@wxiaoguang
Copy link
Contributor

You could test it by adding 2 lines there.

Actually, according to my test, these JS code could be all removed. Because Fomantic UI Tab already does everything for "switching"

image

@silverwind silverwind enabled auto-merge (squash) February 17, 2024 16:20
@silverwind silverwind disabled auto-merge February 17, 2024 16:20
wxiaoguang
wxiaoguang requested changes Feb 17, 2024
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to try to remove the JS code completely? Fomantic UI Tab should work.

Feel free to dismiss this change request.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Feb 17, 2024
@yardenshoham
Copy link
Member Author

I'd need some help with this. Could anyone take over this PR?

@delvh
Copy link
Member

delvh commented Feb 17, 2024

The whole file or simply this method?
The Oauth method looks like it does stuff on top…

@wxiaoguang
Copy link
Contributor

The whole file or simply this method? The Oauth method looks like it does stuff on top…

Sorry, my typo, I meant "JS code", will try to push and share some screenshots

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 17, 2024 •
edited
Loading

By removing initUserAuthLinkAccountView, it still works.

Fomantic UI Tab uses data-tab to switch elements. https://fomantic-ui.com/modules/tab.html

Screenshots:

image

image

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Feb 17, 2024
@yardenshoham yardenshoham changed the title Remove jQuery from "link account" page Remove unneccesary initUserAuthLinkAccountView from "link account" page Feb 17, 2024
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 17, 2024
@delvh delvh merged commit 3da2c63 into go-gitea:main Feb 17, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 17, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 17, 2024
@yardenshoham yardenshoham deleted the user-auth-jquery branch February 17, 2024 17:52
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 18, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
530f74f 
* giteaofficial/main: (28 commits)
  Improve TrHTML and add more tests (go-gitea#29228)
  Convert visibility to number (go-gitea#29226)
  Implement some action notifier functions (go-gitea#29173)
  Artifact deletion in actions ui (go-gitea#27172)
  Update docs for actions variables (go-gitea#29239)
  Refactor more code in templates  (go-gitea#29236)
  Use "Safe" modifier for manually constructed safe HTML strings in templates (go-gitea#29227)
  Remove jQuery from the repo release form (go-gitea#29225)
  Make submit event code work with both jQuery event and native event (go-gitea#29223)
  Remove jQuery from repo migrate page (go-gitea#29219)
  Remove unneccesary `initUserAuthLinkAccountView` from "link account" page (go-gitea#29217)
  Fix labels referencing the wrong ID in the user profile settings (go-gitea#29199)
  Fix label `for` pointing to a `name` instead of `id` in webhook settings (go-gitea#29209)
  Load outdated comments when (un)resolving conversation on PR timeline (go-gitea#29203)
  Fix missing template for follow button in organization (go-gitea#29215)
  Enable markdownlint `no-trailing-punctuation` and `no-blanks-blockquote` (go-gitea#29214)
  Remove jQuery from the webhook editor (go-gitea#29211)
  Remove jQuery from issue reference context popup attach (go-gitea#29216)
  fix typo (go-gitea#29212)
  Fix debian InRelease Acquire-By-Hash newline (go-gitea#29204)
  ...
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@yardenshoham @wxiaoguang @silverwind
Remove unneccesary initUserAuthLinkAccountView from "link account" …
3180059 
…page (go-gitea#29217)

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Feb 26, 2024
@yardenshoham @earl-warren
Remove unneccesary initUserAuthLinkAccountView from "link account" …
66bae32 
…page (go-gitea#29217)

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
(cherry picked from commit 3da2c63)
@github-actions GitHub Actions
Copy link

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@yardenshoham @silverwind @wxiaoguang @delvh @GiteaBot