Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make actions animation rotate counterclockwisely #29378

Merged
merged 3 commits into from
Feb 25, 2024
Merged

Make actions animation rotate counterclockwisely #29378

merged 3 commits into from
Feb 25, 2024

Conversation

wxiaoguang
Copy link
Contributor

Because the icon is:

image

So it must rotate counterclockwisely

@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Feb 24, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 24, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 24, 2024
@delvh
Copy link
Member

delvh commented Feb 24, 2024

Looks weird to me.
What about mirroring the icon instead?
Should be a transform: scaleX(-1);

@wxiaoguang
Copy link
Contributor Author

Looks weird to me. What about mirroring the icon instead? Should be a transform: scaleX(-1);

Could you edit this PR directly? 🙏

@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Feb 24, 2024 •
edited
Loading

Looks weird to me. What about mirroring the icon instead? Should be a transform: scaleX(-1);

Could you edit this PR directly? 🙏

Hmm ...

TBH at the moment I can't make transform: scaleX(-1); work on this element, because it also affects the animation, the icon just flips again and again .... maybe need more tricks and test: eg: move the transform to upper level? (it seems to need more changes 🤣 )

delvh
delvh approved these changes Feb 24, 2024
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the current state is also fine if flipping the image makes to many problems

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 24, 2024
yardenshoham
yardenshoham approved these changes Feb 25, 2024
View reviewed changes
Copy link
Member

@yardenshoham yardenshoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add a before/after gifs in the description

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 25, 2024
@yardenshoham yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 25, 2024
@lunny lunny merged commit ea164ab into go-gitea:main Feb 25, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 25, 2024
@wxiaoguang wxiaoguang deleted the fix-job-icon-rotate branch February 25, 2024 14:06
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 26, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
2575481 
* giteaofficial/main: (45 commits)
  Include resource state events in Gitlab downloads (go-gitea#29382)
  Add API to get PR by base/head (go-gitea#29242)
  [skip ci] Updated translations via Crowdin
  Improve Documentation for Restoration from backup (go-gitea#29321)
  Refactor "user/active" related logic (go-gitea#29390)
  Remove jQuery AJAX from the archive download links (go-gitea#29380)
  Add tailwindcss (go-gitea#29357)
  Add missing space (go-gitea#29393)
  Integrate alpine `noarch` packages into other architectures index (go-gitea#29137)
  enforce maxlength in frontend (go-gitea#29389)
  Remove incorrect and unnecessary Escape from templates (go-gitea#29394)
  Make actions animation rotate counterclockwisely (go-gitea#29378)
  Use `crypto/sha256` (go-gitea#29386)
  Add `io.Closer` guidelines (go-gitea#29387)
  Remove jQuery AJAX from the notice selection deletion button (go-gitea#29381)
  Refactor Safe modifier (go-gitea#29392)
  Add attachment support for code review comments (go-gitea#29220)
  Refactor modules/git global variables (go-gitea#29376)
  Remove jQuery from the code diff expansion buttons (go-gitea#29385)
  Remove jQuery AJAX from the markdown editor preview (go-gitea#29384)
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @delvh @yardenshoham @lunny @GiteaBot