Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lighten text colors on dark theme for increased contrast #29481

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Lighten text colors on dark theme for increased contrast #29481

merged 3 commits into from
Feb 29, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Feb 28, 2024 •
edited
Loading

Improve contrast by lightening the text colors in dark theme by around 35%. Additionally, share some variables that had the same or similar color, which will ease future theme creation.

Before:

Screenshot 2024-02-29 at 00 39 14

After:

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 28, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 28, 2024
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 28, 2024
@silverwind silverwind changed the title Lighten text colors on dark theme Lighten text colors on dark theme for increased contrast Feb 29, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 29, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 29, 2024
@techknowlogick techknowlogick enabled auto-merge (squash) February 29, 2024 05:06
@techknowlogick techknowlogick added the topic/accessibility This issue/pull request wants to improve the accessibility label Feb 29, 2024
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 29, 2024
@techknowlogick techknowlogick merged commit e94e2fb into go-gitea:main Feb 29, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 29, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 29, 2024
@silverwind silverwind deleted the textcolor branch February 29, 2024 09:07
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 29, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
0ac2d7a 
* giteaofficial/main:
  Lighten text colors on dark theme for increased contrast (go-gitea#29481)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@denyskon denyskon denyskon approved these changes

@lafriks lafriks lafriks approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/accessibility This issue/pull request wants to improve the accessibility
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
6 participants
@silverwind @lunny @lafriks @denyskon @techknowlogick @GiteaBot