Fix incorrect diff expander for deletion of last lines in a file #29501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
delvh
approved these changes
Feb 29, 2024
GiteaBot
added
lgtm/need 1
yardenshoham
approved these changes
Mar 1, 2024
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 2, 2024
* giteaofficial/main: Actions Artifacts v4 backend (go-gitea#28965) Remove jQuery AJAX from common global functions (go-gitea#29528) Allow options to disable user gpg keys configuration from the interface on app.ini (go-gitea#29486) [skip ci] Updated translations via Crowdin Fix issue & comment history bugs (go-gitea#29525) Fix incorrect diff expander for deletion of last lines in a file (go-gitea#29501) Ignore `__debug_bin*` which is generated by vscode when debugging (go-gitea#29524)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #29498
I don't quite understand this code, but this change does seem to fix the issue and I tested a number of diffs with it and saw no issue. The function gets such value if last line is an addition:
If it's a deletion, it gets:
So I think it's correct to make this check respect both left and right side.