Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify search boxes #29530
Unify search boxes #29530
Changes from 30 commits
9fc1cee
3420d76
cbf68b6
0827d70
68737d1
64d0b72
d647d6a
11dca6e
f57d864
74e70b7
d9b35e3
142ff7c
732b74e
e04497d
94208c1
5774a2c
33f0bab
7525ce0
f1d15fa
788ac65
a7b955f
1dfadb6
dd14dc4
c1dcf7f
8c2d0e4
22124c4
0539de3
e222490
40a58c6
b67c1f5
655fcdd
948a98d
75afa66
f49e69d
3d2d213
ea418f3
8aaa5ca
2372dc3
0601976
d5a1c84
329c2f4
91f7e35
b64a6e9
d17d86e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you delete that template?
Why not simply leave it in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can answer your question. That's caused by an over-abstraction in old days.
At that time,
admin/base/search
was designed to be a "shared template" and was expected to be used everywhere. But over time, that design didn't fit more and more cases, so the "shared template" usages were replaced by dedicated code block one by one, then, here is the only last one place which uses the "shared template" nowadays.This file was deleted.
This file was deleted.
This file was deleted.