Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 500 when deleting account with incorrect password or unsupported login type #29579

Merged
merged 7 commits into from
Mar 8, 2024
Merged

Fix 500 when deleting account with incorrect password or unsupported login type #29579

merged 7 commits into from
Mar 8, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 4, 2024

Fix #26210

@lunny lunny added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 labels Mar 4, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 4, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 4, 2024
JakobDev
JakobDev reviewed Mar 4, 2024
View reviewed changes
modules/base/type.go Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 4, 2024
@yp05327
Copy link
Contributor

yp05327 commented Mar 6, 2024

Another question: why even it is marked as required, but can be empty when sending the request.
image

@lunny
Copy link
Member Author

lunny commented Mar 6, 2024

Another question: why even it is marked as required, but can be empty when sending the request. image

That could be another problem. I think it needs the frontend changes before the model popup.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 7, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 8, 2024
@lunny @wolfogre
Update routers/web/user/setting/account.go
681ae6a 
Co-authored-by: Jason Song <i@wolfogre.com>
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 8, 2024
@lunny lunny enabled auto-merge (squash) March 8, 2024 03:58
@lunny lunny merged commit ce8a98f into go-gitea:main Mar 8, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 8, 2024
@GiteaBot
Copy link
Collaborator

GiteaBot commented Mar 8, 2024

I was unable to create a backport for 1.21. @lunny, please send one manually. 🍵

go run ./contrib/backport 29579
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 8, 2024
@lunny lunny deleted the lunny/fix_delete_account branch March 8, 2024 05:25
lunny added a commit to lunny/gitea that referenced this pull request Mar 8, 2024
@lunny @wolfogre
Fix 500 when deleting account with incorrect password or unsupported …
ffa4ae0 
…login type (go-gitea#29579)

Fix go-gitea#26210

---------

Co-authored-by: Jason Song <i@wolfogre.com>
@lunny lunny mentioned this pull request Mar 8, 2024
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Mar 8, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 8, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
92a5738 
* giteaofficial/main:
  Filter for default-branch selection (go-gitea#29388)
  Fixing the issue when status check per rule matches multiple actions (go-gitea#29631)
  Fix 500 when deleting account with incorrect password or unsupported login type (go-gitea#29579)
  Partially enable MSSQL case-sensitive collation support (go-gitea#29238)
@lunny lunny modified the milestones: 1.23.0, 1.22.0 Mar 8, 2024
6543 pushed a commit that referenced this pull request Mar 8, 2024
@lunny @wolfogre
Fix 500 when deleting account with incorrect password or unsupported …
a129c0c 
…login type (#29579) (#29656)

Fix #26210
Backport #29579

Co-authored-by: Jason Song <i@wolfogre.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JakobDev JakobDev JakobDev left review comments

@wolfogre wolfogre wolfogre approved these changes

@wxiaoguang wxiaoguang wxiaoguang left review comments

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Delete user account functionality broken.
7 participants
@lunny @yp05327 @GiteaBot @silverwind @wxiaoguang @wolfogre @JakobDev