Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect package link method calls in templates #29580

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Fix incorrect package link method calls in templates #29580

merged 2 commits into from
Mar 4, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Mar 4, 2024 •
edited
Loading

Fix #29562.

Follow #29531 . Fix the links in templates.

@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Mar 4, 2024
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Mar 4, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 4, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 4, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Mar 4, 2024
@wxiaoguang
Copy link
Contributor Author

It is a regression of #29531 , I forgot to replace the names in templates to the new one.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 4, 2024
Zettat123
Zettat123 approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@Zettat123 Zettat123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix #29562?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2024
@wxiaoguang wxiaoguang mentioned this pull request Mar 4, 2024
Closed
@wxiaoguang wxiaoguang enabled auto-merge (squash) March 4, 2024 10:26
@wxiaoguang wxiaoguang merged commit 7ec4c65 into go-gitea:main Mar 4, 2024
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-pkg-link branch March 4, 2024 11:13
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 4, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
79032d9 
* giteaofficial/main:
  Document that all unmerged feature PRs will be moved to next milestone when the feature freeze time comes (go-gitea#29578)
  Make admin pages wider because of left sidebar added and some tables become too narrow (go-gitea#29581)
  Refactor star/watch button (go-gitea#29576)
  Remove unnecessary SanitizeHTML from code (go-gitea#29575)
  Add missing database transaction for new issue (go-gitea#29490)
  Fix incorrect package link method calls in templates (go-gitea#29580)
  Move some asymkey functions to service layer (go-gitea#28894)
  Add user blocking (go-gitea#29028)

# Conflicts:
#	templates/repo/issue/view_content/context_menu.tmpl
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
@wxiaoguang wxiaoguang added the backport/v1.21 This PR should be backported to Gitea 1.21 label Mar 13, 2024
This was referenced Mar 13, 2024
Closed
Merged
@wxiaoguang wxiaoguang added backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! labels Mar 13, 2024
@go-gitea go-gitea unlocked this conversation Mar 13, 2024
lunny pushed a commit that referenced this pull request Mar 13, 2024
@wxiaoguang
Fix incorrect package link method calls in templates (#29580) (#29764)
bb2640c 
Backport #29580
Fix #29562
Fix #29762
Follow  #29531
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@Zettat123 Zettat123 Zettat123 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

500 when opening repo packages page
5 participants
@wxiaoguang @lunny @KN4CK3R @Zettat123 @GiteaBot