Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight archived labels #29680

Merged
merged 12 commits into from
Mar 12, 2024
Merged

Highlight archived labels #29680

merged 12 commits into from
Mar 12, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Mar 8, 2024 •
edited
Loading

the issue is, that you can not distinguish between normal and archived labels.

So this will make archived labels 80% grayscale. And prepend "Archived: " to the tooltip info

image
image
image
image

Sponsored by Kithara Software GmbH

@6543
highlight archived labels
147c902 
set a border and change the tooltip
@6543 6543 added type/enhancement An improvement of existing functionality topic/ux How users interact with Gitea labels Mar 8, 2024
@6543 6543 requested a review from silverwind March 8, 2024 19:07
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 8, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 8, 2024
@6543 6543 changed the title highlight archived labels Highlight archived labels Mar 8, 2024
@silverwind

This comment was marked as outdated.

Sign in to view
@6543

This comment was marked as outdated.

Sign in to view
@silverwind

This comment was marked as resolved.

Sign in to view
@6543 6543 changed the title Highlight archived labels [WIP] Highlight archived labels Mar 8, 2024
@6543 6543 added the pr/wip This PR is not ready for review label Mar 8, 2024
@6543

This comment was marked as outdated.

Sign in to view
@6543 6543 requested a review from confusedsushi March 11, 2024 20:44
@6543 6543 removed the pr/wip This PR is not ready for review label Mar 11, 2024
@6543 6543 changed the title [WIP] Highlight archived labels Highlight archived labels Mar 11, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 12, 2024
@lunny
Copy link
Member

lunny commented Mar 12, 2024 •
edited
Loading

How about remove the color or make it grey?

delvh
delvh reviewed Mar 12, 2024
View reviewed changes
web_src/css/repo.css Outdated Show resolved Hide resolved
modules/templates/util_render.go Show resolved Hide resolved
6543
6543 commented Mar 12, 2024
View reviewed changes
web_src/css/repo.css Outdated Show resolved Hide resolved
6543
6543 commented Mar 12, 2024
View reviewed changes
web_src/css/repo.css Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Mar 12, 2024

addressed it all & updated screenshots

@6543 6543 closed this Mar 12, 2024
@6543 6543 reopened this Mar 12, 2024
delvh
delvh reviewed Mar 12, 2024
View reviewed changes
web_src/css/repo.css Outdated Show resolved Hide resolved
modules/templates/util_render.go Outdated Show resolved Hide resolved
modules/templates/util_render.go Show resolved Hide resolved
6543 and others added 3 commits March 12, 2024 17:55
@6543 @delvh
Update modules/templates/util_render.go
1cd3dc1 
Co-authored-by: delvh <dev.lh@web.de>
@6543 @delvh
Update modules/templates/util_render.go
4c9b9ad 
Co-authored-by: delvh <dev.lh@web.de>
@6543 @delvh
Update web_src/css/repo.css
de42f7f 
Co-authored-by: delvh <dev.lh@web.de>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 12, 2024
@6543 6543 added this to the 1.22.0 milestone Mar 12, 2024
@6543 6543 enabled auto-merge (squash) March 12, 2024 17:18
@6543 6543 added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 12, 2024
@6543 6543 disabled auto-merge March 12, 2024 17:19
@6543 6543 enabled auto-merge (squash) March 12, 2024 17:19
confusedsushi
confusedsushi reviewed Mar 12, 2024
View reviewed changes
web_src/css/repo.css
@@ -2417,6 +2417,10 @@
gap: 0 !important;
}

.archived-label {
filter: grayscale(0.8);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think gray scale the color is unfortunate as it might collide with labels which have already a gray color. However, that's good enough for me now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And that's already the improved version 😁
#29680 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a css class now for it, we can itterate and improve on it

Copy link
Member

@silverwind silverwind Mar 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My recommendation is still opacity: .5.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll open a new pull so we can address it here and let the merged pull stay merged ("quiet") ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> #29749

@6543 6543 merged commit 36de5b2 into go-gitea:main Mar 12, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 12, 2024
@6543 6543 deleted the highlight_archived_labels branch March 12, 2024 17:51
@6543 6543 mentioned this pull request Mar 13, 2024
Merged
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 13, 2024
@wxiaoguang
Copy link
Contributor

Regression: Project boards fail to render after newest docker nightly update #29770

executing "repo/issue/card" at <RenderLabel>: wrong number of args for RenderLabel: want 3 got 2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@confusedsushi confusedsushi confusedsushi left review comments

@jolheiser jolheiser jolheiser approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

@silverwind silverwind Awaiting requested review from silverwind

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/ux How users interact with Gitea type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
9 participants
@6543 @silverwind @lunny @wxiaoguang @confusedsushi @a1012112796 @jolheiser @delvh @GiteaBot