-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WebHookEditor regression from jQuery removal #29692
Merged
wxiaoguang
merged 3 commits into
go-gitea:main
from
yardenshoham:fix-webhookeditor-regression
Mar 9, 2024
Merged
Fix WebHookEditor regression from jQuery removal #29692
wxiaoguang
merged 3 commits into
go-gitea:main
from
yardenshoham:fix-webhookeditor-regression
Mar 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make these calls optional Signed-off-by: Yarden Shoham <git@yardenshoham.com>
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Mar 9, 2024
pull-request-size
bot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Mar 9, 2024
yardenshoham
added
type/bug
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
labels
Mar 9, 2024
delvh
approved these changes
Mar 9, 2024
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Mar 9, 2024
Maybe it's clearer to do so:
|
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
pull-request-size
bot
added
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
and removed
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Mar 9, 2024
Now, another JS error:
Update: oops, rebuild JS (4d1ffda) and no error now. The errors only occur in 4af858f) |
wxiaoguang
approved these changes
Mar 9, 2024
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Mar 9, 2024
Merged
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 9, 2024
* upstream/main: Fix action runner offline label padding (go-gitea#29691) Update allowed attachment types (go-gitea#29688) Completely style the webkit autofill (go-gitea#29683) Include go files in tailwind processing (go-gitea#29686) Fix WebHookEditor regression from jQuery removal (go-gitea#29692)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make these calls optional