Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor query key for fuzzy search #29700

Closed
wants to merge 4 commits into from
Closed

refactor query key for fuzzy search #29700

wants to merge 4 commits into from

Conversation

6543
Copy link
Member

@6543 6543 commented Mar 10, 2024 •
edited by delvh
Loading

Instead of a generic t param, we should use fuzzy as boolean key to enable or disable the fuzzy search.

Additionally, unify the templates.

@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 10, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 10, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 10, 2024
@6543 6543 mentioned this pull request Mar 10, 2024
Merged
@lunny
Copy link
Member

lunny commented Mar 10, 2024

Wouldn't t=fuzzy has better extensible than is_fuzzy?

@6543

This comment was marked as off-topic.

Sign in to view
@6543
Copy link
Member Author

6543 commented Mar 10, 2024

Wouldn't t=fuzzy has better extensible than is_fuzzy?

ah sorry missread it

I dont know what you would extend beside on/off of it.

@denyskon
Copy link
Member

@6543 Can I include your changes into my PR #29530 ? Otherwise it will create conflicts... it will be ready today :)

@6543
Copy link
Member Author

6543 commented Mar 10, 2024

@denyskon ah nice you noticed the dublication ... too

Yes pick as you like.

It would be awesome if after your change, i still be able to add #29701 in a few codechanges as i did.

PS: dont worry if you do things bit different

@denyskon denyskon mentioned this pull request Mar 10, 2024
Merged
@denyskon
Copy link
Member

@6543 Done, please review my PR :)

@denyskon denyskon closed this Mar 10, 2024
@6543 6543 deleted the ui-isFuzzy branch March 10, 2024 17:31
silverwind added a commit that referenced this pull request Mar 14, 2024
@denyskon @6543
@silverwind @GiteaBot
Unify search boxes (#29530)
e0b002a 
Unify all but a few search boxes to use uniform style, uniform
translations and shared templates where possible.
Remove a few duplicated search templates, e. g. code search.

<details><summary>Example after screenshots:</summary>


![grafik](https://github.com/go-gitea/gitea/assets/47871822/e20e7d6b-c6be-4a47-b132-672766f41421)


![grafik](https://github.com/go-gitea/gitea/assets/47871822/d5b11b9c-c12f-4a29-8fb0-24e5aa511d18)


![grafik](https://github.com/go-gitea/gitea/assets/47871822/d86bb444-36c7-426d-9cf1-c634963dffb1)


![grafik](https://github.com/go-gitea/gitea/assets/47871822/a76c0319-0518-484a-a840-563d02b61198)

</details>


Also includes #29700 

Co-authored-by: 6543 <6543@obermui.de>

---------

Co-authored-by: 6543 <m.huber@kithara.com>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Giteabot <teabot@gitea.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh left review comments

Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @lunny @denyskon @delvh @GiteaBot