-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable tailwind nesting #29746
enable tailwind nesting #29746
Conversation
Won't this also get us postcss-nested? Seems like a nonstandard nesting syntax I would like to avoid. Generally I'm fine with nesting syntax currently if it's standard syntax and when it's compiled to flat syntax for compat. |
We already have Line 11504 in 857243b
@silverwind, would you prefer to use |
Yeah, it's a dependency of tailwindcss, but my preference would be standard nesting syntax, transpiled to flat syntax until PaleMoon gains support, or just not use it until then 😆. |
Seems https://github.com/csstools/postcss-plugins/tree/main/plugins/postcss-nesting, so please add that as dependency and make it use that, also set edition to latest, which will make removing the plugin later easier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Yes looks good besides that topic above. I will also give it a test later. |
One final question: What is the motivation for this PR? We don't have any CSS nesting in the code yet as far as I'm aware. Is it for customization or are you preparing a PR that will use it? |
We use CSS nesting within our fork. I thought this would be a good candidate to push upstream because others may eventually use nesting in their PRs. |
Ok, personally I wouldn't use it, but we can give people this option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fixed in 9a7482f. The magic option |
* giteaofficial/main: Update JS dependences (go-gitea#29797) Unify search boxes (go-gitea#29530) Fix document error about 'make trans-copy' (go-gitea#29710) Remove jQuery AJAX from the diff functions (go-gitea#29743) Fix Safari spinner rendering (go-gitea#29801) Remove jQuery AJAX from the `repo-issue.js` file (go-gitea#29776) Improve commit record's ui in comment list (go-gitea#26619) enable tailwind nesting (go-gitea#29746)
Currently, if you implement native CSS nesting within a Vue component a warning will appear in the terminal. It states
Nested CSS was detected, but CSS nesting has not been configured correctly. Please enable a CSS nesting plugin *before* Tailwind in your configuration.
To fix this error we need to enable the built-in tailwinds nesting config.Example code to trigger the warning within a vue component: