Support GITEA_I_AM_BEING_UNSAFE_RUNNING_AS_ROOT env #29788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
wolfogre
added
skip-changelog
wxiaoguang
reviewed
Mar 14, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Mar 14, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
added
lgtm/need 1
wxiaoguang
removed
lgtm/need 1
wxiaoguang
reviewed
Mar 14, 2024
GiteaBot
added
the
lgtm/done
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
wolfogre
added
the
reviewed/wait-merge
GiteaBot
added a commit
to GiteaBot/gitea
that referenced
this pull request
Mar 14, 2024
It is convenient to skip by setting environment, since it's OK to use root user in job containers. It's not a bug, but I want to backport it to v1.21 since it doesn't break anything. --------- Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
GiteaBot
added
backport/done
wolfogre
added a commit
that referenced
this pull request
Mar 14, 2024
Backport #29788 by @wolfogre I was trying to run unit tests for Gitea on act runner, by using `make test`. It failed with log: ``` 2024/03/14 03:09:26 ...s/setting/setting.go:180:loadRunModeFrom() [F] Gitea is not supposed to be run as root. Sorry. If you need to use privileged TCP ports please instead use setcap and the `cap_net_bind_service` permission ``` So it will be convenient to skip by setting environment, since it's OK to use root user in job containers. It's not a bug, but I want to backport it to v1.21 since it doesn't break anything. --------- Co-authored-by: Jason Song <i@wolfogre.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 14, 2024
* giteaofficial/main: Support GITEA_I_AM_BEING_UNSAFE_RUNNING_AS_ROOT env (go-gitea#29788) Fix missing translation on milestons (go-gitea#29785) Fix lint-swagger warning (go-gitea#29787) Tweak actions view sticky (go-gitea#29781) add skip ci support for pull request title (go-gitea#29774) Refactor markup/csv: don't read all to memory (go-gitea#29760)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to run unit tests for Gitea on act runner, by using
make test.It failed with log:
So it will be convenient to skip by setting environment, since it's OK to use root user in job containers.
It's not a bug, but I want to backport it to v1.21 since it doesn't break anything.