Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvements for pull request list page #29900

Merged
merged 18 commits into from
Mar 21, 2024
Merged

Performance improvements for pull request list page #29900

merged 18 commits into from
Mar 21, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 19, 2024 •
edited
Loading

This PR will avoid load pullrequest.Issue twice in pull request list page. It will reduce x times database queries for those WIP pull requests.

Partially fix #29585

@lunny lunny added the performance/speed performance issues with slow downs label Mar 19, 2024
@lunny lunny added this to the 1.22.0 milestone Mar 19, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 19, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 19, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 19, 2024
@lunny lunny added the backport/v1.21 This PR should be backported to Gitea 1.21 label Mar 19, 2024
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/templates This PR modifies the template files labels Mar 19, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 20, 2024
@wolfogre wolfogre added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 20, 2024
@GiteaBot

This comment was marked as outdated.

Sign in to view
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 20, 2024
silverwind
silverwind approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 20, 2024
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 21, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 21, 2024
@silverwind silverwind merged commit 62f8174 into go-gitea:main Mar 21, 2024
26 checks passed
@GiteaBot
Copy link
Collaborator

I was unable to create a backport for 1.21. @lunny, please send one manually. 🍵

go run ./contrib/backport 29900
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 21, 2024
@silverwind
Copy link
Member

@lunny could you please always enable auto-merge when you set reviewed/wait-merge? If you don't it will just uselessly consume CI resources with all those merges.

@lunny lunny deleted the lunny/pulls_performance branch March 21, 2024 13:14
lunny added a commit to lunny/gitea that referenced this pull request Mar 21, 2024
@lunny @GiteaBot
Performance improvements for pull request list page (go-gitea#29900)
10a9161 
This PR will avoid load pullrequest.Issue twice in pull request list
page. It will reduce x times database queries for those WIP pull
requests.

Partially fix go-gitea#29585

---------

Co-authored-by: Giteabot <teabot@gitea.io>
@lunny lunny mentioned this pull request Mar 21, 2024
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Mar 21, 2024
@lunny
Copy link
Member Author

lunny commented Mar 21, 2024

@lunny could you please always enable auto-merge when you set reviewed/wait-merge? If you don't it will just uselessly consume CI resources with all those merges.

I just not do that to leave some time for other maintainers.

@silverwind
Copy link
Member

silverwind commented Mar 21, 2024 •
edited
Loading

Maybe we should adjust the bot so it does not continuosly merge (and waste ci time) with that label, but instead only do that when auto-merge is set.

silverwind added a commit to silverwind/gitea that referenced this pull request Mar 21, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into npmlink
62b58d5 
* origin/main: (332 commits)
  Refactor external URL detection (go-gitea#29973)
  Refactor repo header/list (go-gitea#29969)
  Fix various loading states, remove `.loading` class (go-gitea#29920)
  Update register application URL for GitLab (go-gitea#29959)
  Refactor StringsToInt64s (go-gitea#29967)
  Switch to happy-dom for testing (go-gitea#29948)
  Performance improvements for pull request list page (go-gitea#29900)
  Refactor URL detection (go-gitea#29960)
  Solving the issue of UI disruption when the review is deleted without refreshing (go-gitea#29951)
  Fix JS error and improve error message styles (go-gitea#29963)
  Fix the bug that user may logout if he switch pages too fast (go-gitea#29962)
  Cancel previous runs of the same PR automatically (go-gitea#29961)
  Exclude `routers/private/tests` from air (go-gitea#29949)
  Remove codecov badge (go-gitea#29950)
  Misc color tweaks (go-gitea#29943)
  Fix and rewrite markup anchor processing (go-gitea#29931)
  Remove fomantic grid module (go-gitea#29894)
  Add background to dashboard navbar, fix missing padding (go-gitea#29940)
  Prevent layout shift in `<overflow-menu>` items (go-gitea#29831)
  Fix loadOneBranch panic (go-gitea#29938)
  ...
wolfogre pushed a commit that referenced this pull request Mar 22, 2024
@lunny
Performance improvements for pull request list page (#29900) (#29972)
6ef986d 
This PR will avoid load pullrequest.Issue twice in pull request list
page. It will reduce x times database queries for those WIP pull
requests.

Partially fix #29585
Backport #29900
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 22, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
3597d77 
* giteaofficial/main:
  Fix bugs in rerunning jobs (go-gitea#29955)
  remove PATH and GOPATH modification in Makefile (go-gitea#29978)
  Refactor external URL detection (go-gitea#29973)
  Refactor repo header/list (go-gitea#29969)
  Fix various loading states, remove `.loading` class (go-gitea#29920)
  Update register application URL for GitLab (go-gitea#29959)
  Refactor StringsToInt64s (go-gitea#29967)
  Switch to happy-dom for testing (go-gitea#29948)
  Performance improvements for pull request list page (go-gitea#29900)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@wolfogre wolfogre wolfogre approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files performance/speed performance issues with slow downs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Very slow to load pages @1.21.7
5 participants
@lunny @GiteaBot @silverwind @wxiaoguang @wolfogre