Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Organization Interface Display Issue #30133

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Conversation

HEREYUA
Copy link
Contributor

@HEREYUA HEREYUA commented Mar 27, 2024

Before

image

After

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 27, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 27, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Mar 27, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 27, 2024
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but that isn't right. There should only be one .page-content on the page, with this there would be two. secondary-nav is meant for a nav below the main nav, but in this case it does not fit because there is the org header above.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 27, 2024
@silverwind
Copy link
Member

I think this needs some margins added, ideally so that these two divider lines align:

image

@HEREYUA
Copy link
Contributor Author

HEREYUA commented Mar 27, 2024

Sorry, I didn't know I couldn't continue to use .page-content .secondary-nav on this page. I will proceed with the modifications

@wxiaoguang
Copy link
Contributor

Agree, it is not right. page-content is quite special, it means the "main content of a page", it shouldn't be abused anywhere else.

@HEREYUA
Copy link
Contributor Author

HEREYUA commented Mar 27, 2024

I think this needs some margins added, ideally so that these two divider lines align:

Updated, The dividing lines cannot be perfectly aligned unless more detailed fine-tuning is done
image
image

current
image

@silverwind
Copy link
Member

I think to properly fix the line alignment those elements need to be put into the same <div>, but that's something for another PR.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Mar 27, 2024
@lunny lunny added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 27, 2024
@lunny lunny enabled auto-merge (squash) March 27, 2024 12:19
@lunny lunny merged commit 0262c66 into go-gitea:main Mar 27, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 27, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 27, 2024
@techknowlogick techknowlogick modified the milestones: 1.23.0, 1.22.0 Mar 28, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants