Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various overflows on actions view #30344

Merged
merged 11 commits into from
Apr 15, 2024
Merged

Fix various overflows on actions view #30344

merged 11 commits into from
Apr 15, 2024

Conversation

silverwind
Copy link
Member

Fix a number of text overflow issues in actions view and run list. Also improve mobile view of run list.

Fixes: #30328

Screenshot 2024-04-08 at 23 10 16 Screenshot 2024-04-08 at 23 17 46 Screenshot 2024-04-08 at 23 49 05 Screenshot 2024-04-08 at 23 55 30

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 8, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 8, 2024
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/js labels Apr 8, 2024
@silverwind silverwind added backport/v1.22 This PR should be backported to Gitea 1.22 and removed modifies/templates This PR modifies the template files modifies/js labels Apr 8, 2024
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/js labels Apr 8, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 9, 2024
@silverwind silverwind requested review from yp05327 and delvh April 10, 2024 17:56
@yp05327
Copy link
Contributor

yp05327 commented Apr 12, 2024 •
edited
Loading

image
How about adding a max length to the title, then it will look better.

wxiaoguang
wxiaoguang reviewed Apr 12, 2024
View reviewed changes
web_src/css/actions.css Outdated Show resolved Hide resolved
@silverwind
Copy link
Member Author

image How about adding a max length to the title, then it will look better.

image

@wxiaoguang wxiaoguang mentioned this pull request Apr 14, 2024
Merged
@silverwind silverwind mentioned this pull request Apr 14, 2024
Merged
@silverwind silverwind mentioned this pull request Apr 14, 2024
Merged
@silverwind
Copy link
Member Author

The max-width revert is included here, everything looks fine currently:

Screenshot 2024-04-14 at 22 06 13 Screenshot 2024-04-14 at 22 06 26

wxiaoguang added a commit that referenced this pull request Apr 15, 2024
@silverwind @wxiaoguang
Revert 100% label max-width (#30481)
ef3941f 
Partial revert of #30479

It's causing problems at least here:
#30344 (comment)

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 15, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 15, 2024
@silverwind silverwind enabled auto-merge (squash) April 15, 2024 18:52
@silverwind silverwind merged commit b9f69b4 into go-gitea:main Apr 15, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 15, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 15, 2024
@silverwind @GiteaBot
Fix various overflows on actions view (go-gitea#30344)
e338d3d 
Fix a number of text overflow issues in actions view and run list. Also
improve mobile view of run list.

Fixes: go-gitea#30328

<img width="782" alt="Screenshot 2024-04-08 at 23 10 16"
src="https://github.com/go-gitea/gitea/assets/115237/3d9f9f88-3eab-44a0-8144-30c2b58b24cb">
<img width="935" alt="Screenshot 2024-04-08 at 23 17 46"
src="https://github.com/go-gitea/gitea/assets/115237/581d73ea-a31d-416b-be3a-47313b879b12">
<img width="1008" alt="Screenshot 2024-04-08 at 23 49 05"
src="https://github.com/go-gitea/gitea/assets/115237/c5d10565-f285-477f-8659-1caf94797647">
<img width="397" alt="Screenshot 2024-04-08 at 23 55 30"
src="https://github.com/go-gitea/gitea/assets/115237/368aaa75-1903-4058-9d75-d1fe91c564d6">
@GiteaBot GiteaBot mentioned this pull request Apr 15, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Apr 15, 2024
silverwind added a commit that referenced this pull request Apr 16, 2024
@GiteaBot @silverwind
Fix various overflows on actions view (#30344) (#30505)
00179f6 
Backport #30344 by @silverwind

Fix a number of text overflow issues in actions view and run list. Also
improve mobile view of run list.

Fixes: #30328

<img width="782" alt="Screenshot 2024-04-08 at 23 10 16"
src="https://github.com/go-gitea/gitea/assets/115237/3d9f9f88-3eab-44a0-8144-30c2b58b24cb">
<img width="935" alt="Screenshot 2024-04-08 at 23 17 46"
src="https://github.com/go-gitea/gitea/assets/115237/581d73ea-a31d-416b-be3a-47313b879b12">
<img width="1008" alt="Screenshot 2024-04-08 at 23 49 05"
src="https://github.com/go-gitea/gitea/assets/115237/c5d10565-f285-477f-8659-1caf94797647">
<img width="397" alt="Screenshot 2024-04-08 at 23 55 30"
src="https://github.com/go-gitea/gitea/assets/115237/368aaa75-1903-4058-9d75-d1fe91c564d6">

Co-authored-by: silverwind <me@silverwind.io>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 16, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
9c37592 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix various overflows on actions view (go-gitea#30344)
  Convert max file name length to 255 (go-gitea#30489)
  Remove active border on pointing menu (go-gitea#30486)
  Fix button color on red and green buttons (go-gitea#30500)
  Fix code owners will not be mentioned when a pull request comes from a forked repository (go-gitea#30476)
  Fix overflow on issue dependency (go-gitea#30484)
  Kill all gitea processes before air build (go-gitea#30477)
@silverwind silverwind deleted the actov branch April 16, 2024 14:48
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Apr 22, 2024
@silverwind @algernon
Revert 100% label max-width (#30481)
ff30628 
Partial revert of go-gitea/gitea#30479

It's causing problems at least here:
go-gitea/gitea#30344 (comment)

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
(cherry picked from commit ef3941f2ebe9d8353f9546e7df00b24092c71cb7)
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

@yp05327 yp05327 Awaiting requested review from yp05327

@delvh delvh Awaiting requested review from delvh

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js modifies/templates This PR modifies the template files size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Better action list UI for long commit message and branch name?
5 participants
@silverwind @yp05327 @lunny @wxiaoguang @GiteaBot