Add project column choice option on issue sidebar #30617
Conversation
Signed-off-by: a1012112796 <1012112796@qq.com>
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/translation
modifies/go
|
A change comment need to be created when switching successfully. |
That's another feature which is out of the topic of current pull request... |
Signed-off-by: a1012112796 <1012112796@qq.com>
No, I don't think so. It should be created with the same database transaction. |
see #30703, it's not a small change like what you see... |
|
Considering multi project support, maybe using modal later is a good choice. |
|
Please resolve the conflicts, sorry the rename PR results in conflicts. |
lunny
changed the title
models/project/issue.go
Outdated
| } | ||
| defer committer.Close() | ||
|
|
||
| num, err := toColumn.NumIssues(ctx) |
There was a problem hiding this comment.
This is not right. If you update two columns, then they will have the same sorting.
There was a problem hiding this comment.
but this function only can update one column.
There was a problem hiding this comment.
I mean one by one.
I think it okay, becaue when call it one by one, NumIssues also will be canged one by one. else which sorting should be seted in this usage? zero?
There was a problem hiding this comment.
looks in moveIssuesToAnotherColumn(), it use max() sql function to get new sorting, I have use same logic in a824db0, how about this?
Signed-off-by: a1012112796 <1012112796@qq.com>
Announce it again. This PR may cause big conflict in Web UI with #30381. |
|
Fix #13520? |
example:
