Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get repo assignees and reviewers should ignore deactivated users (#30770) #30782

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Get repo assignees and reviewers should ignore deactivated users (#30770) #30782

merged 3 commits into from
Apr 30, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Apr 30, 2024

Backport #30770

If an user is deactivated, it should not be in the list of users who are suggested to be assigned or review-requested.

old assignees or reviewers are not affected.

Sponsored by Kithara Software GmbH

@6543
Get repo assignees and reviewers should ignore deactivated users (go-…
32412d6 
…gitea#30770)

If an user is deactivated, it should not be in the list of users who are
suggested to be assigned or review-requested.

old assignees or reviewers are not affected.

---
*Sponsored by Kithara Software GmbH*
@GiteaBot GiteaBot added this to the 1.22.0 milestone Apr 30, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 30, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 30, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 30, 2024
@6543 6543 added the type/bug label Apr 30, 2024
@6543 6543 mentioned this pull request Apr 30, 2024
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 30, 2024
@6543 6543 changed the title Get repo assignees and reviewers should ignore deactivated users) Get repo assignees and reviewers should ignore deactivated users (#30770) Apr 30, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 30, 2024
@silverwind silverwind enabled auto-merge (squash) April 30, 2024 13:20
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 30, 2024
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 30, 2024
@silverwind silverwind merged commit 022eac4 into go-gitea:release/v1.22 Apr 30, 2024
26 checks passed
@6543 6543 deleted the backport_22_30770 branch April 30, 2024 15:38
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 30, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @lunny @silverwind @GiteaBot