Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change --border-radius-circle to --border-radius-full #30936

Merged
merged 3 commits into from
May 25, 2024
Merged

Change --border-radius-circle to --border-radius-full #30936

merged 3 commits into from
May 25, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented May 10, 2024 •
edited
Loading

Percentage-based border-radius creates undesirable ellipse on non-square content. Instead, use pixel value and use same wording full like tailwind does, but increast to 99999px over their 9999px.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 10, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 10, 2024
@silverwind
Copy link
Member Author

silverwind commented May 10, 2024 •
edited
Loading

CSS recently gained support for an infinity value so calc(infinity * 1px) should work in recent browsers, but I think it's still too early to make use of that. Also, it's not actually infinite.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 10, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 19, 2024
@wxiaoguang wxiaoguang added the backport/v1.22 This PR should be backported to Gitea 1.22 label May 19, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 20, 2024
@GiteaBot
Copy link
Contributor

@silverwind please fix the merge conflicts. 🍵

@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 20, 2024
@lunny
Copy link
Member

lunny commented May 21, 2024

@silverwind please resolve the conflicts.

@github-actions github-actions bot added modifies/translation modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/templates This PR modifies the template files modifies/docs modifies/internal modifies/dependencies labels May 25, 2024
@pull-request-size pull-request-size bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 25, 2024
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 25, 2024
@github-actions github-actions bot removed modifies/translation modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/templates This PR modifies the template files modifies/docs modifies/internal modifies/dependencies labels May 25, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 25, 2024
@lunny lunny enabled auto-merge (squash) May 25, 2024 14:29
@lunny lunny merged commit 2ced31e into go-gitea:main May 25, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 25, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 25, 2024
@silverwind @GiteaBot
Change --border-radius-circle to --border-radius-full (go-gitea#3…
b0d59d1 
…0936)

Percentage-based `border-radius` [creates undesirable
ellipse](https://jsfiddle.net/silverwind/j9ko5wnt/4/) on non-square
content. Instead, use pixel value and use same wording `full` like
tailwind does, but increast to 99999px over their 9999px.
@GiteaBot GiteaBot mentioned this pull request May 25, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels May 25, 2024
lunny pushed a commit that referenced this pull request May 26, 2024
@GiteaBot
Change --border-radius-circle to --border-radius-full (#30936) (#…
7b73182 
…31078)
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 27, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
9d1e929 
* giteaofficial/main:
  [skip ci] Updated licenses and gitignores
  Make gitea webhooks openproject compatible (go-gitea#28435)
  Change `--border-radius-circle` to `--border-radius-full` (go-gitea#30936)
  Fix `View File` button link if branch deleted on pull request files pages (go-gitea#31063)
@silverwind silverwind deleted the radius-full branch May 27, 2024 21:24
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
6 participants
@silverwind @GiteaBot @lunny @techknowlogick @wxiaoguang @delvh