Add API route for explore/code search #31515
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/api
knudtty
force-pushed
the
code-search-api
branch
2 times, most recently
from
f85c521
to
1232a01
Compare
kemzeb
suggested changes
Jul 3, 2024
GiteaBot
added
lgtm/blocked
|
Whoops, did not mean to block this PR as my review is just general feedback. A maintainer with write access should be able to resolve this. |
knudtty
force-pushed
the
code-search-api
branch
2 times, most recently
from
853a39b
to
3eab528
Compare
maantje
reviewed
Sep 16, 2024
| @@ -890,6 +891,14 @@ func Routes() *web.Router { | |||
| // Misc (public accessible) | |||
| m.Group("", func() { | |||
| m.Get("/version", misc.Version) | |||
| m.Group("/explore", func() { | |||
There was a problem hiding this comment.
Shouldn't the API route be /search/code to align with the naming conventions of the GitHub API?
Suggested change
| m.Group("/explore", func() { | |
| m.Group("/search", func() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31375
Creates an API endpoint at /explore/code to use the same code search from the web endpoint for /explore/code. This reuses as much code as possible from the web version without modifying behavior. New files have been added for the api route, return structs, and swagger.
Note for testing: You must set
REPO_INDEXER_ENABLED = truein your app.ini config.