Use FullName in Emails to address the recipient if possible #31527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
6543
commented
Jun 29, 2024
6543
commented
Jun 29, 2024
delvh
reviewed
Jun 29, 2024
silverwind
reviewed
Jul 1, 2024
silverwind
reviewed
Jul 1, 2024
Co-authored-by: silverwind <me@silverwind.io>
silverwind
approved these changes
Jul 4, 2024
GiteaBot
added
lgtm/need 1
6543
added a commit
to 6543-forks/gitea
that referenced
this pull request
Jul 5, 2024
delvh
reviewed
Jul 7, 2024
| return u.Email | ||
| } | ||
|
|
||
| return fmt.Sprintf("%s <%s>", mime.QEncoding.Encode("utf-8", add.Name), add.Address) |
There was a problem hiding this comment.
Why not encode the sanitizedDisplayName beforehand?
There was a problem hiding this comment.
Because then the mime encoding is undone
| @@ -413,6 +415,34 @@ func (u *User) DisplayName() string { | |||
| return u.Name | |||
| } | |||
|
|
|||
| var emailToReplacer = strings.NewReplacer( | |||
There was a problem hiding this comment.
emailNameReplacer?
I don't see any reason why we should only use it for To.
There was a problem hiding this comment.
Right now we do, if it gets reused some can just rename it
delvh
approved these changes
Jul 7, 2024
GiteaBot
added
lgtm/done
6543
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 9, 2024
* giteaofficial/main: Use FullName in Emails to address the recipient if possible (go-gitea#31527) Don't show hidden labels when filling out an issue template (go-gitea#31576) [skip ci] Updated translations via Crowdin Convert frontend code to typescript (go-gitea#31559) [skip ci] Updated translations via Crowdin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we had just the plain mail address as recipient. But now we provide additional Information for the Mail clients.
Sponsored by Kithara Software GmbH