Don't init oauth if settings have it disabled #31533
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
added
the
backport/v1.22
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
…is it is possible to have suprious jwt/ directories all over the place
delvh
reviewed
Jul 1, 2024
| @@ -30,6 +30,11 @@ const ProviderHeaderKey = "gitea-oauth2-provider" | |||
|
|
|||
| // Init initializes the oauth source | |||
| func Init(ctx context.Context) error { | |||
| // if oauth is disabled, we don't need to initialize anything | |||
| if !setting.OAuth2.Enable { | |||
There was a problem hiding this comment.
According to the CI, this should be called
Suggested change
| if !setting.OAuth2.Enable { | |
| if !setting.OAuth2.Enabled { |
| @@ -30,6 +30,11 @@ const ProviderHeaderKey = "gitea-oauth2-provider" | |||
|
|
|||
| // Init initializes the oauth source | |||
| func Init(ctx context.Context) error { | |||
| // if oauth is disabled, we don't need to initialize anything | |||
| if !setting.OAuth2.Enable { | |||
| return | |||
There was a problem hiding this comment.
Suggested change
| return | |
| return nil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30266
Patch credit to: @hawicz