Add a new section named development in issue view sidebar to interact with branch/pr

[lunny]

Partially Resolve #20226

This PR add a new section on the sidebar of issue named Development. It supports creating one or multiple branches and pull requests from the sidebar.

1. No related branch or PR
   

2. Create new branch from the issue

3. Related branch created

4. Prefill title and content when creating pull request from the issue development link
   

5. Realted PR created
   

6. Related PR merged
   

7. Mayge fixed near the issue title
   

TODO:

• Delete dev_link records from the database when deleting repos/issues
• Delete dev_link records from the database when deleting pull requests/branch
• Allow creating multiple branches/pull requests from UI
• Bring issue information into the pull request when creating the pull request.
• Adjust the toast z-index to 9999 so that it will display in front of the modal.

[yp05327]

Wouldn't it be expected?

Personally, I don't think it is good.
If you only edited the form and closed the form without creating a new branch, the warning will display.

Can you post an screenshot? I can't reproduce it. See my screenshots in updated issue content.

[lunny]

Wouldn't it be expected?

Personally, I don't think it is good. If you only edited the form and closed the form without creating a new branch, the warning will display.

The logic is derived from all other forms. All other forms have the same behaviour to avoid user losing their content accidentally.

Can you post an screenshot? I can't reproduce it. See my screenshots in updated issue content.

Looks like it's a common bug which caused almost all the dropdown list.

This has been fixed in 029a444

[lunny]

The UI seems not good, if there's many PRs or branches, it looks disorganized

Spaces added.

[yp05327]

Locale is missing

[lunny]

Locale is missing

Fixed in f2a28d0

[lunny]

Fixed in f2a28d0

Not only one. All of them are missing.

These locale strings should be there.

[yp05327]

We have branch table, so this can be int64?
ps: Commit SHA seems meaningless

[lunny]

In future PRs, we can link a commit to this issue. So it will be kept to support that. BTW: Azure supports linking to a commit. I think for some development model, they just push commits with no feature branches or pull requests, they can use this feature.

[yp05327]

Then it can be split into to columns. LinkIndex(int64) and LinkRef(string)?
Using string type means you need to convert it from/to int64 type every time if it is a PR ID or branch ID which seems not good.

[lunny]

Then it can be split into to columns. LinkIndex(int64) and LinkRef(string)? Using string type means you need to convert it from/to int64 type every time if it is a PR ID or branch ID which seems not good.

The conversion is on the memory and we don't know what data we will store according to different LinkType. And this column will never be used as index, so we don't need to consider performance or as search condition.

[wxiaoguang]

I also agree it doesn't seem to be a good name or proper design. There are already too many "index" in code: search index, database index, issue index, etc.

And using "string" to store "int" in database would cause problems, if you write ("where str_field = ?", intVal), then it can't use the index and would cause imperceptible performance problems.

[yp05327]

This section should be hidden or disabled when repo is empty or repo is archive or repo is mirror.

[lunny]

This section should be hidden or disabled when repo is empty or repo is archive or repo is mirror.

The links are still useable. Only create branch link should be hide.

[wxiaoguang]

Just tried to play with GitHub's development sidebar for a while. I can see there could be a lot of edge cases:

1. create a new branch 123-my-issue, rename the branch to 123-my-issue-other, the link disappears, rename another branch to 123-my-issue, the link won't appear again.
2. create a new branch 123-my-issue, create a PR from 123-my-issue, then the link is updated to PR, the branch link is replaced.

I believe these details need enough documents(comments) and tests.

[wxiaoguang]

I guess it won't catch 1.23 milestone since this PR doesn't seem to be complete enough.

---

LinkIndex: I also agree it doesn't seem to be a good name or proper design. There are already too many "index" in code: search index, database index, issue index, etc.

And using "string" to store "int" in database would cause problems, if you write ("where str_field = ?", intVal), then it can't use the index and would cause imperceptible performance problems.

---

Just tried to play with GitHub's development sidebar for a while. I can see there could be a lot of edge cases:

1. create a new branch 123-my-issue, rename the branch to 123-my-issue-other, the link disappears, rename another branch to 123-my-issue, the link won't appear again.
2. create a new branch 123-my-issue, create a PR from 123-my-issue, then the link is updated to PR, the branch link is replaced.

I believe these details need enough documents(comments) and tests.