Updated tokenizer to better matching when search for code snippets #32261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
…earch case insensitive) Signed-off-by: Bruno Sofiato <bruno.sofiato@gmail.com>
bsofiato
force-pushed
the
feature/sane-tokenizer
branch
from
20b22db to
312f706
Compare
|
I think you can change the version, for users upgrade from stable release to next release, they will still only upgrade index only one time. |
lunny
reviewed
Oct 23, 2024
tests/gitea-repositories-meta/org42/search-by-path.git/objects/info/commit-graph
Outdated
Show resolved
Hide resolved
OK :) |
Done !!! |
lunny
approved these changes
Oct 24, 2024
GiteaBot
added
lgtm/need 1
|
bleve's version should also be upgraded. |
Done |
|
last Call @go-gitea/technical-oversight-committee |
wolfogre
approved these changes
Nov 6, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 7, 2024
* giteaofficial/main: Add new index for action to resolve the performance problem (go-gitea#32333) Include file extension checks in attachment API (go-gitea#32151) Updated tokenizer to better matching when search for code snippets (go-gitea#32261) Correctly query the primary button in a form (go-gitea#32438) # Conflicts: # web_src/js/utils/dom.ts
matera-bs
pushed a commit
to matera-ar/gitea
that referenced
this pull request
Nov 14, 2024
…matching when search for code snippets (go-gitea#32261) This PR improves the accuracy of Gitea's code search. Currently, Gitea does not consider statements such as `onsole.log("hello")` as hits when the user searches for `log`. The culprit is how both ES and Bleve are tokenizing the file contents (in both cases, `console.log` is a whole token). In ES' case, we changed the tokenizer to [simple_pattern_split](https://www.elastic.co/guide/en/elasticsearch/reference/current/analysis-simplepatternsplit-tokenizer.html#:~:text=The%20simple_pattern_split%20tokenizer%20uses%20a,the%20tokenization%20is%20generally%20faster.). In such a case, tokens are words formed by digits and letters. In Bleve's case, it employs a [letter](https://blevesearch.com/docs/Tokenizers/) tokenizer. Resolves go-gitea#32220 --------- Signed-off-by: Bruno Sofiato <bruno.sofiato@gmail.com>
matera-bs
pushed a commit
to matera-ar/gitea
that referenced
this pull request
Dec 17, 2024
…matching when search for code snippets (go-gitea#32261) This PR improves the accuracy of Gitea's code search. Currently, Gitea does not consider statements such as `onsole.log("hello")` as hits when the user searches for `log`. The culprit is how both ES and Bleve are tokenizing the file contents (in both cases, `console.log` is a whole token). In ES' case, we changed the tokenizer to [simple_pattern_split](https://www.elastic.co/guide/en/elasticsearch/reference/current/analysis-simplepatternsplit-tokenizer.html#:~:text=The%20simple_pattern_split%20tokenizer%20uses%20a,the%20tokenization%20is%20generally%20faster.). In such a case, tokens are words formed by digits and letters. In Bleve's case, it employs a [letter](https://blevesearch.com/docs/Tokenizers/) tokenizer. Resolves go-gitea#32220 --------- Signed-off-by: Bruno Sofiato <bruno.sofiato@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the accuracy of Gitea's code search.
Currently, Gitea does not consider statements such as
onsole.log("hello")as hits when the user searches forlog. The culprit is how both ES and Bleve are tokenizing the file contents (in both cases,console.logis a whole token).In ES' case, we changed the tokenizer to simple_pattern_split. In such a case, tokens are words formed by digits and letters. In Bleve's case, it employs a letter tokenizer.
Resolves #32220