Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RepoActionView.vue, add ::group:: support #32713

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Refactor RepoActionView.vue, add ::group:: support #32713

merged 3 commits into from
Dec 6, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Dec 4, 2024 •
edited
Loading

  1. make it able to "force reload", then the previous pending request won't block the new request
  2. make it support ::group::
  3. add some TS types (but there are still many variables untyped, this PR is large enough, the remaining types could be added in the future)

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 4, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 4, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/frontend labels Dec 4, 2024
This was referenced Dec 4, 2024
Closed
Open
@wxiaoguang wxiaoguang added this to the 1.23.0 milestone Dec 4, 2024
@wxiaoguang wxiaoguang force-pushed the refactor-action-log branch 2 times, most recently from afb44c8 to f978b7b Compare December 4, 2024 10:28
@wxiaoguang wxiaoguang changed the title Refactor RepoActionView.vue Refactor RepoActionView.vue, add group support Dec 4, 2024
@wxiaoguang wxiaoguang added the type/enhancement An improvement of existing functionality label Dec 4, 2024
@wxiaoguang wxiaoguang requested a review from silverwind December 4, 2024 16:59
@wxiaoguang wxiaoguang force-pushed the refactor-action-log branch 3 times, most recently from 164b7dc to 612e5a2 Compare December 4, 2024 17:31
@silverwind
Copy link
Member

AbortController definitely seems like the best option. I was actually thinking about using it too.

@wxiaoguang wxiaoguang mentioned this pull request Dec 4, 2024
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 4, 2024
@lunny lunny requested a review from wolfogre December 4, 2024 22:41
@lunny lunny requested a review from Zettat123 December 4, 2024 22:41
@wxiaoguang wxiaoguang changed the title Refactor RepoActionView.vue, add group support Refactor RepoActionView.vue, add ::group:: support Dec 5, 2024
@silverwind
Copy link
Member

silverwind commented Dec 5, 2024 •
edited
Loading

Maybe we can put the triangle at the start of the line like GitHub has:

image

Also, I think with that, no z-index tricks will be needed.

@wxiaoguang
Copy link
Contributor Author

Maybe we can put the triangle at the start of the line like GitHub has:
Also, I think with that, no z-index tricks will be needed.

I do not see a quick approach to do so. The z-index is the simplest approach and the most performant, it only uses <details> and a few lines of CSS, not ideal but good enough.

Since this PR is large enough and has already done many things, I think the UI improvement doesn't block and the UI could always be improved in following PRs. And not only the UI, there are indeed many TODOs for this Vue component.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 6, 2024
@wxiaoguang wxiaoguang merged commit f7f68e4 into go-gitea:main Dec 6, 2024
26 checks passed
@wxiaoguang wxiaoguang deleted the refactor-action-log branch December 6, 2024 04:04
@wxiaoguang wxiaoguang mentioned this pull request Dec 8, 2024
Draft
6 tasks
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 9, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
24b0634 
* giteaofficial/main:
  [skip ci] Updated licenses and gitignores
  Fix repo home row-right grow (go-gitea#32763)
  Refactor issue list (go-gitea#32755)
  Fix compare page bug view as anonymous (go-gitea#32754)
  Split issue/pull view router function as multiple smaller functions (go-gitea#32749)
  fix: render job title as commit message (go-gitea#32748)
  Fix typescript errors in Vue files, fix regression in "Recent Commits" chart (go-gitea#32649)
  Refactor LabelEdit (go-gitea#32752)
  [skip ci] Updated translations via Crowdin
  fix(project): add title to project view page (go-gitea#32747)
  [skip ci] Updated translations via Crowdin
  Fix case of .tsbuildinfo in .gitignore (go-gitea#32737)
  Support "merge upstream branch" (Sync fork) (go-gitea#32741)
  Update changelog to add missed changelog (go-gitea#32734)
  GitHub like repo home page (go-gitea#32213)
  Refactor markdown render (go-gitea#32736)
  Make wiki pages visit fast (go-gitea#32732)
  Refactor markdown render (go-gitea#32728)
  Refactor RepoActionView.vue, add `::group::` support (go-gitea#32713)
@wxiaoguang wxiaoguang mentioned this pull request Dec 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zettat123 Zettat123 Zettat123 approved these changes

@lunny lunny lunny approved these changes

@wolfogre wolfogre Awaiting requested review from wolfogre

@silverwind silverwind Awaiting requested review from silverwind

@techknowlogick techknowlogick Awaiting requested review from techknowlogick

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @silverwind @lunny @Zettat123 @GiteaBot