Make RepoActionView.vue support ##[group]
#32770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
6 tasks
github-actions
bot
added
modifies/go
wxiaoguang
force-pushed
the
fix-action-log
branch
from
cb095d1 to
6fbeb1d
Compare
wxiaoguang
force-pushed
the
fix-action-log
branch
from
6fbeb1d to
7328516
Compare
|
Can this be written in a testable fashion? E.g. actions log string in and assert presence of certain HTML elements in rendered output. |
|
Yes and no.
So in the future we should keep refactoring this Vue component (there are still many TODOs for it) |
By the way, all of "parseLineCommand", "beginLogGroup", "endLogGroup" and "appendLogs" are testable, as long as export them. Intentionally I decoupled them from the Vue SFC. While I guess we do not need to do that test in this PR. |
silverwind
reviewed
Dec 9, 2024
| @@ -393,7 +413,7 @@ export function initRepositoryActionView() { | |||
| <button class="ui basic small compact button red" @click="cancelRun()" v-else-if="run.canCancel"> | |||
| {{ locale.cancel }} | |||
| </button> | |||
| <button class="ui basic small compact button tw-mr-0 tw-whitespace-nowrap link-action" :data-url="`${run.link}/rerun`" v-else-if="run.canRerun"> | |||
| <button class="ui basic small compact button link-action" :data-url="`${run.link}/rerun`" v-else-if="run.canRerun"> | |||
There was a problem hiding this comment.
tw-mr-0should eliminate a 4px margin-right caused by button CSS, can we restore it? I was meaning to remove this margin from CSS but have not gotten around to it yet.tw-whitespace-nowrapshould prevent the button text from ever wrapping, like on small viewport. Did you check?
There was a problem hiding this comment.
Ah I see you put replacement CSS below. Is margin between buttons still present?
There was a problem hiding this comment.
These buttons are all in if-else
The tw-mr-0 you added was only on the last else button.
silverwind
approved these changes
Dec 9, 2024
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Dec 10, 2024
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 10, 2024
* giteaofficial/main: Make RepoActionView.vue support `##[group]` (go-gitea#32770) [skip ci] Updated translations via Crowdin Make Monaco theme follow browser, fully type codeeditor.ts (go-gitea#32756) Fix duplicate dropdown dividers (go-gitea#32760) Remove unnecessary border in repo home page sidebar (go-gitea#32767)
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Dec 10, 2024
* origin/main: Fix internal server error when updating labels without write permission (go-gitea#32776) Fix wiki ui (go-gitea#32781) Change typescript `module` to `nodenext` (go-gitea#32757) Refactor issue filter (labels, poster, assignee) (go-gitea#32771) Make RepoActionView.vue support `##[group]` (go-gitea#32770) [skip ci] Updated translations via Crowdin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.