Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #33149

Merged
merged 16 commits into from
Jan 10, 2025
Merged

Update README.md #33149

merged 16 commits into from
Jan 10, 2025

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Jan 8, 2025 •
edited
Loading

Waiting for the upload of screenshots
I have a good idea about the screenshots. I will do it later.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 8, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 8, 2025
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2025
@yp05327 yp05327 mentioned this pull request Jan 8, 2025
Closed
20 tasks
techknowlogick
techknowlogick reviewed Jan 8, 2025
View reviewed changes
README.md Outdated Show resolved Hide resolved
@techknowlogick
Copy link
Member

If you have screenshots already, you can upload them here and I'll upload them to dl.gitea.com

@yp05327
Copy link
Contributor Author

yp05327 commented Jan 8, 2025

If you have screenshots already, you can upload them here and I'll upload them to dl.gitea.com

I have sent them to @lunny yesterday.

@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2025
@yp05327
Copy link
Contributor Author

yp05327 commented Jan 10, 2025

I have a new idea about how to update screenshots automatically. I should do some prepares, so in this PR I will not touch it.

@yp05327 yp05327 marked this pull request as ready for review January 10, 2025 05:11
@yp05327 yp05327 requested review from lunny and a team and removed request for lunny January 10, 2025 05:11
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 10, 2025
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Jan 10, 2025
@yp05327 yp05327 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 10, 2025
BLumia
BLumia suggested changes Jan 10, 2025
View reviewed changes
Copy link
Member

@BLumia BLumia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

中文 README 请保持使用全角顿号、逗号、句号。目前新增的段落都存在混用的情况。

The Chinese-language README should using full-width characters. Currently we had a mix of full-width and half-width characters usage in the newly introduced contents.

README_ZH.md Outdated Show resolved Hide resolved
README_ZH.md Outdated Show resolved Hide resolved
README_ZH.md Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 10, 2025
@yp05327
Copy link
Contributor Author

yp05327 commented Jan 10, 2025 •
edited
Loading

中文 README 请保持使用全角顿号、逗号、句号。目前新增的段落都存在混用的情况。

@BLumia
原来的中文README中就存在半角全角符号混用。所以我在修改的时候就很confuse。如果有这个规定，我会重新检查所有符号。

The original Chinese README already had a mix of full-width and half-width characters, which made me quite confused while editing. If there is such a rule, I will go back and thoroughly check all the symbols.

e.g. https://github.com/go-gitea/gitea/blob/main/README_ZH.md#%E6%8F%90%E7%A4%BA
image

@BLumia
Copy link
Member

BLumia commented Jan 10, 2025 •
edited
Loading

原来的中文README中就存在半角全角符号混用。
The original Chinese README already had a mix of full-width and half-width characters

我知道，所以觉得既然比较大篇幅的修订就可以顺带改掉来着。
I know, that's why IMO we can also address this issue since you already rewriting/reworking the content itself.

如果有这个规定，我会重新检查所有符号。
If there is such a rule

现在应当没有这个规定，但出于文本规范性角度而言，建议进行修正。
I believe we don't have such guideline for now, but from the perspective of textual standardization, I suggest we also address this issue here.

（如果你完全没有计划在这个 PR 做这件事的话，可以说一下，我就不因此 request change 了）
(if you don't intended to do this, let me know and I'll no longer request change for this issue)

@yp05327
Copy link
Contributor Author

yp05327 commented Jan 10, 2025

现在应当没有这个规定，但出于文本规范性角度而言，建议进行修正。

（如果你完全没有计划在这个 PR 做这件事的话，可以说一下，我就不因此 request change 了）

No, this request makes sence, will be done in this PR.

yp05327 and others added 4 commits January 10, 2025 16:07
@yp05327 @BLumia
Update README_ZH.md
77e3a81 
Co-authored-by: Gary Wang <git@blumia.net>
@yp05327 @BLumia
Update README_ZH.md
9bfc62e 
Co-authored-by: Gary Wang <git@blumia.net>
@yp05327 @BLumia
Update README_ZH.md
e273145 
Co-authored-by: Gary Wang <git@blumia.net>
@yp05327
convert half-width characters into full-width characters in zh readme
f2e08cb
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Jan 10, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 10, 2025
@lunny lunny merged commit 5c150ce into go-gitea:main Jan 10, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 10, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 10, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 14, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
589d5fc 
* giteaofficial/main: (21 commits)
  Support public code/issue access for private repositories (go-gitea#33127)
  Validate that the tag doesn't exist when creating a tag via the web (go-gitea#33241)
  [skip ci] Updated translations via Crowdin
  Switch back to `vue-tsc` (go-gitea#33248)
  Let API create and edit system webhooks, attempt 2 (go-gitea#33180)
  Fix incorrect ref "blob" (go-gitea#33240)
  Refactor RefName (go-gitea#33234)
  Refactor context RefName and RepoAssignment (go-gitea#33226)
  [skip ci] Updated translations via Crowdin
  Fix upload file form (go-gitea#33230)
  Fix mirror bug (go-gitea#33224)
  Remove unused CSS styles and move some styles to proper files (go-gitea#33217)
  Refactor context repository (go-gitea#33202)
  [skip ci] Updated translations via Crowdin
  Fix unpin hint on the pinned pull requests (go-gitea#33207)
  fix(cache): cache test triggered by non memory cache (go-gitea#33220)
  Update README.md (go-gitea#33149)
  Fix editor markdown not incrementing in a numbered list (go-gitea#33187)
  Some small refactors (go-gitea#33144)
  Fix sync fork for consistency (go-gitea#33147)
  ...
@yp05327 yp05327 deleted the update-readme branch January 17, 2025 05:13
@yp05327 yp05327 mentioned this pull request Jan 22, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techknowlogick techknowlogick techknowlogick left review comments

@lunny lunny lunny approved these changes

@BLumia BLumia BLumia approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs modifies/internal size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@yp05327 @techknowlogick @BLumia @lunny @GiteaBot