Add a transaction to pickTask
#33543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/api
lunny
reviewed
Feb 10, 2025
lunny
approved these changes
Feb 11, 2025
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Feb 11, 2025
GiteaBot
added
lgtm/done
yp05327
approved these changes
Feb 11, 2025
Yes. I think there is no need to change it. |
Ship of Theseus https://en.wikipedia.org/wiki/Ship_of_Theseus (ps: personally I never review the "license header" changes, as long as lint passes, I do not care .......) |
|
I was unable to create a backport for 1.23. @Zettat123, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
lunny
pushed a commit
to lunny/gitea
that referenced
this pull request
Feb 11, 2025
In the old `pickTask`, when getting secrets or variables failed, the task could get stuck in the `running` status (task status is `running` but the runner did not fetch the task). To fix this issue, these steps should be in one transaction. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 12, 2025
* giteaofficial/main: Add a transaction to `pickTask` (go-gitea#33543) Fix context usage (go-gitea#33554)
lunny
added a commit
that referenced
this pull request
Feb 12, 2025
Backport #33543 In the old `pickTask`, when getting secrets or variables failed, the task could get stuck in the `running` status (task status is `running` but the runner did not fetch the task). To fix this issue, these steps should be in one transaction. --------- Co-authored-by: Zettat123 <zettat123@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the old
pickTask, when getting secrets or variables failed, the task could get stuck in therunningstatus (task status isrunningbut the runner did not fetch the task). To fix this issue, these steps should be in one transaction.